Re: [PATCH V3] m68knommu: driver for Freescale Coldfire I2C controller.

[Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

Hi,

> While they are physically similar, just as the mpc and the imx are physically 
> similar, the imx driver has a lot of imx'isms, device tree and OF 
> dependencies that aren't supported by the m68k/nommu.

Devicetree/OF should be optional. If not, we need to fix it anyhow. So,
the question is how much imx'ism there is really in there.

> I would expect the changes needed tantamount to having separate
> drivers.

If that is really true, then two seperate drivers might be the right
choice. Yet, I'd like to base this decision on facts and not
expectations (which might be wrong). I understand that you worked on the
driver for some time now, from a maintanence point of view having only
one driver is preferable, though. That works at least for fec.c.

>  Plus I have no way of testing what impact any changes I made had on
>  the imx functionality, so I expect I would end up mostly just
>  annoying the imx developers.

I am an imx-developer and I won't be annoyed :)

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]