All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Marcus Karlsson <mk@acc.umu.se>
Cc: thomas@m3y3r.de, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts_pstor: fixed some coding style errors
Date: Tue, 12 Jun 2012 10:37:03 -0700	[thread overview]
Message-ID: <20120612173703.GA2499@kroah.com> (raw)
In-Reply-To: <1338496799-13437-1-git-send-email-mk@acc.umu.se>

On Thu, May 31, 2012 at 10:39:59PM +0200, Marcus Karlsson wrote:
> Fixed some code styling errors in the following files:
> 
> drivers/staging/rts_pstor/rtsx_scsi.c:
> * multiple statements on single line
> 
> drivers/staging/rts_pstor/trace.h:
> * trailing whitespace
> * non-enclosed macro
> 
> drivers/staging/rts_pstor/xd.c:
> * trailing whitespace

Please break this up into individual patches, each doing one thing.
Doing all of this in one large patch makes it much harder to review.

thanks,

greg k-h

      reply	other threads:[~2012-06-12 17:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-31 20:39 [PATCH] staging: rts_pstor: fixed some coding style errors Marcus Karlsson
2012-06-12 17:37 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120612173703.GA2499@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mk@acc.umu.se \
    --cc=thomas@m3y3r.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.