From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ben Chan <benchan@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, Sage Ahn <syahn@gctsemi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gdm72xx: Fix spinlock recursion on gdm_usb_send_complete
Date: Tue, 12 Jun 2012 22:23:59 +0300 [thread overview]
Message-ID: <20120612192359.GY4400@mwanda> (raw)
In-Reply-To: <1339048886-11956-1-git-send-email-benchan@chromium.org>
On Wed, Jun 06, 2012 at 11:01:26PM -0700, Ben Chan wrote:
> This patch fixes a spinlock recursion bug on several call sites of
> gdm_usb_send_complete by not calling spin_lock_irqsave on
> urb->context->tx_cxt->lock when the lock has already been acquired.
>
> Signed-off-by: Ben Chan <benchan@chromium.org>
> Cc: Sage Ahn <syahn@gctsemi.com>
> ---
Ben doesn't want this patch appied. He sent a version 2 in a later
thread.
regards,
dan carpenter
prev parent reply other threads:[~2012-06-12 19:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 6:01 [PATCH] staging: gdm72xx: Fix spinlock recursion on gdm_usb_send_complete Ben Chan
2012-06-12 19:23 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120612192359.GY4400@mwanda \
--to=dan.carpenter@oracle.com \
--cc=benchan@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syahn@gctsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.