From: Greg KH <gregkh@linuxfoundation.org>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: add mcp4725 I2C DAC driver
Date: Tue, 12 Jun 2012 14:50:30 -0700 [thread overview]
Message-ID: <20120612215030.GA1625@kroah.com> (raw)
In-Reply-To: <1339171605-2577-1-git-send-email-pmeerw@pmeerw.net>
On Fri, Jun 08, 2012 at 06:06:45PM +0200, Peter Meerwald wrote:
> v5:
> * fix warnings (Jonathan Cameron)
>
> v4:
> * remove unused indio_dev pointer in mcp4725_data (Jonathan Cameron)
> * use u16 instead of unsigned short in mcp4725_data (Jonathan Cameron)
> * #include mcp4725.h from linux/iio/dac/
Shouldn't that file be in include/linux/platform_data/ instead? It
really doesn't have anything to do with iio specifically.
Oh, nevermind, all the other drivers put their platform data in that
directory already, so I guess it's ok. But it might be nice to move all
of them out of there soon...
thanks,
greg k-h
next prev parent reply other threads:[~2012-06-12 21:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 16:06 [PATCH] iio: add mcp4725 I2C DAC driver Peter Meerwald
2012-06-12 21:50 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-06-08 7:07 Peter Meerwald
2012-06-08 7:36 ` Jonathan Cameron
2012-06-07 8:30 Peter Meerwald
2012-06-07 16:07 ` Jonathan Cameron
2012-06-08 7:12 ` Peter Meerwald
2012-06-08 7:34 ` Jonathan Cameron
2012-06-06 21:40 Peter Meerwald
2012-06-07 7:36 ` Jonathan Cameron
2012-04-30 10:27 [PATCH 2/2] " Jonathan Cameron
2012-04-30 13:54 ` [PATCH] " Peter Meerwald
2012-04-30 14:39 ` Jonathan Cameron
2012-04-30 18:37 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120612215030.GA1625@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.