All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pedersen, Thomas" <c_tpeder@qca.qualcomm.com>
To: Joe Perches <joe@perches.com>
Cc: <kvalo@qca.qualcomm.com>, <ath6kl-devel@qualcomm.com>,
	<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath6kl: support rssi threshold for sched scan
Date: Tue, 12 Jun 2012 18:02:38 -0700	[thread overview]
Message-ID: <20120613010238.GA540@pista> (raw)
In-Reply-To: <1339534531.4501.3.camel@joe2Laptop>

On Tue, Jun 12, 2012 at 01:55:31PM -0700, Joe Perches wrote:
> On Tue, 2012-06-12 at 13:46 -0700, Thomas Pedersen wrote:
> > The ath6kl firmware can filter scan results based on rssi. This is
> > useful to limit hosts wakeups on scheduled scans.
> []
> > diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> > index 6f20998..4f20693 100644
> > --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
> > +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> > @@ -3267,6 +3267,16 @@ static int ath6kl_cfg80211_sscan_start(struct wiphy *wiphy,
> >  			return ret;
> >  	}
> >  
> > +	if (test_bit(ATH6KL_FW_CAPABILITY_RSSI_SCAN_THOLD,
> > +		     ar->fw_capabilities)) {
> > +		ret = ath6kl_wmi_set_rssi_filter_cmd(ar->wmi, vif->fw_vif_idx,
> > +						    request->rssi_thold);
> 
> poor argument alignment.
> 
> > +		if (ret) {
> > +			ath6kl_err("failed to set RSSI threshold for scan");
> 
> missing newline termination.

Rats. Thanks Joe.

Thomas

      reply	other threads:[~2012-06-13  1:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-12 20:46 [PATCH] ath6kl: support rssi threshold for sched scan Thomas Pedersen
2012-06-12 20:55 ` Joe Perches
2012-06-13  1:02   ` Pedersen, Thomas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120613010238.GA540@pista \
    --to=c_tpeder@qca.qualcomm.com \
    --cc=ath6kl-devel@qualcomm.com \
    --cc=joe@perches.com \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.