From: Ingo Molnar <mingo@kernel.org>
To: Stephane Eranian <eranian@google.com>
Cc: "Yan, Zheng" <zheng.z.yan@intel.com>,
a.p.zijlstra@chello.nl, mingo@elte.hu, jolsa@redhat.com,
andi@firstfloor.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 0/13] perf: Intel uncore pmu counting support
Date: Wed, 13 Jun 2012 09:38:46 +0200 [thread overview]
Message-ID: <20120613073846.GA8057@gmail.com> (raw)
In-Reply-To: <CABPqkBQmdyfxJ1iFoGt45c84zzzUphosY8Qg76MACX=xdtk_mw@mail.gmail.com>
* Stephane Eranian <eranian@google.com> wrote:
> > Peter suggests keeping the uncore names as they're listed in
> > the intel doc. For Sandybirdge-EP, uncore names are
> > something like: Cbo, iMC, QPI. I think Uncore_Cbo_0 appears
> > better than uncore_Cbo_0
>
> Keeping the name is different from keeping the upper vs. lower
> case letters. I think this need to be case insensitive. What
> does it buy you to be case sensitive? Don't think Intel is
> ever going to create two events which differ only by the lower
> vs. upper case. And, I think that's extra frustration when you
> type the event name because you have to also remember the
> letter case.
Yeah - the right approach is to make it all lowercase in sysfs -
then user-space can tolower() the string provided by the user.
There should be no case sensitivity in event specifications
anywhere.
Thanks,
Ingo
next prev parent reply other threads:[~2012-06-13 7:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 5:37 [PATCH V5 0/13] perf: Intel uncore pmu counting support Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 01/13] perf: Export perf_assign_events Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 02/13] perf: Avoid race between cpu hotplug and installing event Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 03/13] perf: Allow pmu to choose cpu on which to install event Yan, Zheng
2012-06-12 10:17 ` Stephane Eranian
2012-06-13 1:57 ` Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 04/13] perf: Introduce perf_pmu_migrate_context Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 05/13] perf: Generic intel uncore support Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 06/13] perf: Add Nehalem and Sandy Bridge " Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 07/13] perf: Generic pci uncore device support Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 08/13] perf: Add Sandy Bridge-EP uncore support Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 09/13] perf, tool: Use data struct for arg passing in event parse function Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 10/13] perf, tool: Make the event parser reentrantable Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 11/13] perf, tool: Add support to reuse event grammar to parse out terms Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 12/13] perf, tool: Add pmu event alias support Yan, Zheng
2012-06-13 6:58 ` Yan, Zheng
2012-06-12 5:37 ` [PATCH V5 13/13] perf, tool: Add automated test for pure terms parsing Yan, Zheng
2012-06-12 15:38 ` [PATCH V5 0/13] perf: Intel uncore pmu counting support Stephane Eranian
2012-06-13 1:41 ` Yan, Zheng
2012-06-13 3:31 ` Andi Kleen
2012-06-13 7:44 ` Ingo Molnar
2012-06-13 6:37 ` Stephane Eranian
2012-06-13 7:38 ` Ingo Molnar [this message]
2012-06-13 9:02 ` Peter Zijlstra
2012-06-14 2:18 ` Yan, Zheng
2012-06-14 5:41 ` Stephane Eranian
2012-06-27 1:05 ` Stephane Eranian
2012-06-27 2:09 ` Yan, Zheng
2012-06-27 9:10 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613073846.GA8057@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.