From: Ingo Molnar <mingo@kernel.org>
To: Don Zickus <dzickus@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
nzimmer@sgi.com, joe@perches.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v4] watchdog: Quiet down the boot messages
Date: Wed, 13 Jun 2012 09:58:52 +0200 [thread overview]
Message-ID: <20120613075852.GB18819@gmail.com> (raw)
In-Reply-To: <1339448655-28060-1-git-send-email-dzickus@redhat.com>
* Don Zickus <dzickus@redhat.com> wrote:
> After the change, it is simplified to:
> NMI watchdog enabled, takes one hw-pmu counter.
minor nit, the above line in the changelog does not match the
code anymore.
> + static unsigned long cpu0_err;
Please don't use statics inside functions - move it to file
scope, before the function or so.
Thanks,
Ingo
prev parent reply other threads:[~2012-06-13 7:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 21:04 [PATCH v4] watchdog: Quiet down the boot messages Don Zickus
2012-06-13 7:58 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613075852.GB18819@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dzickus@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nzimmer@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.