From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 0/5] mmp audio support Date: Wed, 13 Jun 2012 19:58:48 +0000 Message-ID: <201206131958.49446.arnd@arndb.de> References: <1339409081-10097-1-git-send-email-zhangfei.gao@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1339409081-10097-1-git-send-email-zhangfei.gao@marvell.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org Cc: Eric Miao , Leo Yan , Vinod Koul , Mark Brown , Haojian Zhuang , alsa-devel@vger.kernel.org, Qiao Zhou , Zhangfei Gao , Liam Girdwood , Chao Xie List-Id: alsa-devel@alsa-project.org On Monday 11 June 2012, Zhangfei Gao wrote: > > v1->v2: > modify accroingly with suggestion from Vinod and Mark > remove deprecated chan->private and dma.h > remove prep_slave_sg > remove module_init and move operation to probe > misc change It seems that this driver is missing DT bindings, which really need to get added. The brownstone platform is currently supported using both DT and ATAG probing, but we want to remove the ATAG variant eventually, so adding a new driver for that platform without support for DT booting is a step in the wrong direction. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 13 Jun 2012 19:58:48 +0000 Subject: [PATCH v2 0/5] mmp audio support In-Reply-To: <1339409081-10097-1-git-send-email-zhangfei.gao@marvell.com> References: <1339409081-10097-1-git-send-email-zhangfei.gao@marvell.com> Message-ID: <201206131958.49446.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 11 June 2012, Zhangfei Gao wrote: > > v1->v2: > modify accroingly with suggestion from Vinod and Mark > remove deprecated chan->private and dma.h > remove prep_slave_sg > remove module_init and move operation to probe > misc change It seems that this driver is missing DT bindings, which really need to get added. The brownstone platform is currently supported using both DT and ATAG probing, but we want to remove the ATAG variant eventually, so adding a new driver for that platform without support for DT booting is a step in the wrong direction. Arnd