From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de ([212.227.17.9]:59103 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752849Ab2FMUVh (ORCPT ); Wed, 13 Jun 2012 16:21:37 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support Date: Wed, 13 Jun 2012 20:21:08 +0000 Cc: Thierry Reding , Mitch Bradley , Russell King , Stephen Warren , linux-pci@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Jesse Barnes , Rob Herring , Colin Cross , linux-tegra@vger.kernel.org References: <1339427118-32263-1-git-send-email-thierry.reding@avionic-design.de> <4FD84133.4060401@firmworks.com> <20120613075232.GA6139@avionic-0098.mockup.avionic-design.de> In-Reply-To: <20120613075232.GA6139@avionic-0098.mockup.avionic-design.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Message-Id: <201206132021.09774.arnd@arndb.de> Sender: linux-pci-owner@vger.kernel.org List-ID: On Wednesday 13 June 2012, Thierry Reding wrote: > pci@80000000 { > reg = <0x80000000 0x00001000>; > status = "disabled"; > > #address-cells = <3>; > #size-cells = <2>; > > ranges = <0x80400000 0x80400000 0x00008000 /* I/O */ > 0x90000000 0x90000000 0x08000000 /* non-prefetchable memory */ > 0xa0000000 0xa0000000 0x08000000>; /* prefetchable memory */ > > nvidia,ctrl-offset = <0x0>; > nvidia,num-lanes = <2>; > }; > I believe you will need an "interrupt-map" property here, to map the host interrupts to the INTA-INTD lines of the attached devices. I'm not sure whether we want to have a device_type="pciex" property here. powerpc and sparc seem to use that information, to distinguish a pcie bus from pci or cardbus. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support Date: Wed, 13 Jun 2012 20:21:08 +0000 Message-ID: <201206132021.09774.arnd@arndb.de> References: <1339427118-32263-1-git-send-email-thierry.reding@avionic-design.de> <4FD84133.4060401@firmworks.com> <20120613075232.GA6139@avionic-0098.mockup.avionic-design.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120613075232.GA6139-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Thierry Reding , Mitch Bradley , Russell King , Stephen Warren , linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Jesse Barnes , Rob Herring , Colin Cross , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Wednesday 13 June 2012, Thierry Reding wrote: > pci@80000000 { > reg = <0x80000000 0x00001000>; > status = "disabled"; > > #address-cells = <3>; > #size-cells = <2>; > > ranges = <0x80400000 0x80400000 0x00008000 /* I/O */ > 0x90000000 0x90000000 0x08000000 /* non-prefetchable memory */ > 0xa0000000 0xa0000000 0x08000000>; /* prefetchable memory */ > > nvidia,ctrl-offset = <0x0>; > nvidia,num-lanes = <2>; > }; > I believe you will need an "interrupt-map" property here, to map the host interrupts to the INTA-INTD lines of the attached devices. I'm not sure whether we want to have a device_type="pciex" property here. powerpc and sparc seem to use that information, to distinguish a pcie bus from pci or cardbus. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 13 Jun 2012 20:21:08 +0000 Subject: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support In-Reply-To: <20120613075232.GA6139@avionic-0098.mockup.avionic-design.de> References: <1339427118-32263-1-git-send-email-thierry.reding@avionic-design.de> <4FD84133.4060401@firmworks.com> <20120613075232.GA6139@avionic-0098.mockup.avionic-design.de> Message-ID: <201206132021.09774.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 13 June 2012, Thierry Reding wrote: > pci at 80000000 { > reg = <0x80000000 0x00001000>; > status = "disabled"; > > #address-cells = <3>; > #size-cells = <2>; > > ranges = <0x80400000 0x80400000 0x00008000 /* I/O */ > 0x90000000 0x90000000 0x08000000 /* non-prefetchable memory */ > 0xa0000000 0xa0000000 0x08000000>; /* prefetchable memory */ > > nvidia,ctrl-offset = <0x0>; > nvidia,num-lanes = <2>; > }; > I believe you will need an "interrupt-map" property here, to map the host interrupts to the INTA-INTD lines of the attached devices. I'm not sure whether we want to have a device_type="pciex" property here. powerpc and sparc seem to use that information, to distinguish a pcie bus from pci or cardbus. Arnd