From: Ted Ts'o <tytso@mit.edu>
To: Aditya Kali <adityakali@google.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Avoid unnecessary calls to ext4_mb_load_buddy while reading mb_groups proc file
Date: Wed, 13 Jun 2012 19:52:41 -0400 [thread overview]
Message-ID: <20120613235241.GA22646@thunk.org> (raw)
In-Reply-To: <AANLkTimPwhK1NggZAkCzB8Q29Ogf5SswH1kBbH8WAjX7@mail.gmail.com>
On Fri, Jan 14, 2011 at 02:05:15PM -0800, Aditya Kali wrote:
> Currently ext4_mb_load_buddy is called for every group, irrespective
> of whether the group info is already in memory, while reading
> /proc/fs/ext4/<partition>/mb_groups proc file. For the purpose of
> mb_groups proc file, it is unnecessary to load the file group info
> from disk if it was loaded in past. These calls to ext4_mb_load_buddy
> make reading the mb_groups proc file expensive.
> Also, the locks around ext4_get_group_info are not required.
> This patch modifies the code to call ext4_mb_load_buddy only if the
> group info had never been loaded into memory in past. It also removes
> the mb group locking around ext4_get_group_info call.
>
> Signed-off-by: Aditya Kali <adityakali@google.com>
I realized that this had dropped through the cracks. Sorry!
I've queued this for the next merge window.
- Ted
prev parent reply other threads:[~2012-06-14 0:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 22:05 [PATCH] ext4: Avoid unnecessary calls to ext4_mb_load_buddy while reading mb_groups proc file Aditya Kali
2012-06-13 23:52 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613235241.GA22646@thunk.org \
--to=tytso@mit.edu \
--cc=adityakali@google.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.