All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Haojian Zhuang <hzhuang1@marvell.com>
Cc: Chao Xie <cxie4@marvell.com>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH V2] serial: pxa: add spin lock for console write
Date: Wed, 13 Jun 2012 20:23:36 -0700	[thread overview]
Message-ID: <20120614032336.GA7765@kroah.com> (raw)
In-Reply-To: <25B60CDC2F704E4E9D88FFD52780CB4C060E55D5AF@SC-VEXCH1.marvell.com>

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top


On Wed, Jun 13, 2012 at 08:14:20PM -0700, Haojian Zhuang wrote:
> V2 moves local_irq_save() after clk_prepare_enable().

Then say that in the patch description please.

> The extra empty line is unnecessary.

Great, please remove it :)

> Greg,
> 
> Would you apply this patch?

Please resend it with the above changes made.

thanks,

greg k-h

      reply	other threads:[~2012-06-14  3:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22  4:43 [PATCH V2] serial: pxa: add spin lock for console write Chao Xie
2012-06-12 22:35 ` Greg KH
2012-06-14  3:14   ` Haojian Zhuang
2012-06-14  3:23     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120614032336.GA7765@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=cxie4@marvell.com \
    --cc=hzhuang1@marvell.com \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.