From: Paul Mackerras <paulus@samba.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Nathan Williams <nathan@traverse.com.au>,
Karl Hiramoto <karl@hiramoto.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, John Crispin <blogic@openwrt.org>
Subject: Re: PPPoE performance regression
Date: Thu, 14 Jun 2012 16:18:10 +1000 [thread overview]
Message-ID: <20120614061809.GA10453@drongo> (raw)
In-Reply-To: <1339595401.11011.48.camel@shinybook.infradead.org>
On Wed, Jun 13, 2012 at 02:50:01PM +0100, David Woodhouse wrote:
> On Wed, 2012-06-13 at 10:57 +0100, David Woodhouse wrote:
> > This doesn't look *so* evil... if the basic concept of using
> > skb_orphan() and then setting our own destructor is OK, then I'll work
> > out the rest of the details and do it for l2tp too.
>
> Stupid dwmw2. With patch this time...
> +static void pppoe_skb_destructor(struct sk_buff *skb)
> +{
> + struct sock *sk = skb->sk;
> + struct pppox_sock *po = pppox_sk(sk);
> +
> + atomic_dec(&po->inflight);
> + /* Schedule a call to ppp_output_wakeup(chan), if it was already blocked.
> + Mind for race conditions with another CPU which is in pppoe_xmit()
> + right now. See commit 9d02daf7 in pppoatm. */
> + sock_put(sk);
> +}
Umm, how does ppp_output_wakeup() actually get called?
Paul.
next prev parent reply other threads:[~2012-06-14 6:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1339143949.24571.72.camel@dualcore.traverse>
[not found] ` <1339144110.13998.1.camel@i7.infradead.org>
[not found] ` <1339144954.24571.80.camel@dualcore.traverse>
[not found] ` <1339147045.13998.3.camel@i7.infradead.org>
[not found] ` <1339289425.2661.27.camel@laptop>
2012-06-10 8:32 ` PPPoE performance regression David Woodhouse
2012-06-13 9:57 ` David Woodhouse
2012-06-13 13:50 ` David Woodhouse
2012-06-13 15:55 ` Benjamin LaHaise
2012-06-13 16:11 ` David Woodhouse
2012-06-13 16:31 ` Benjamin LaHaise
2012-06-13 16:32 ` David Laight
2012-06-13 16:59 ` David Woodhouse
2012-06-13 16:53 ` David Woodhouse
2012-06-13 17:21 ` Benjamin LaHaise
2012-06-13 17:43 ` David Woodhouse
2012-06-14 6:18 ` Paul Mackerras [this message]
2012-06-14 6:49 ` David Woodhouse
2012-06-14 10:35 ` David Woodhouse
2012-06-13 20:17 ` Karl Hiramoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120614061809.GA10453@drongo \
--to=paulus@samba.org \
--cc=blogic@openwrt.org \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=karl@hiramoto.org \
--cc=nathan@traverse.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.