From: "陳韋任 (Wei-Ren Chen)" <chenwj@iis.sinica.edu.tw>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org,
"\"陳韋任 (Wei-Ren Chen)\"" <chenwj@iis.sinica.edu.tw>
Subject: Re: [Qemu-devel] Does kvm_fd mean KVM or VCPU fd?
Date: Thu, 14 Jun 2012 18:16:46 +0800 [thread overview]
Message-ID: <20120614101646.GA18229@cs.nctu.edu.tw> (raw)
In-Reply-To: <4FD9AB9A.4080401@redhat.com>
> > I think KVM_CREATE_VCPU should return VCPU fd, right? AFAIK, in KVM
> > world, kvm_fd usually means the fd we get after opening "/dev/kvm".
> > Just want to make sure I understand the code correcly. Thanks.
>
> This is the kvm_fd inside struct CPUState, so it's per-CPU.
Okay, then it's VCPU fd. Don't know rename it or add a comment to indicate
it's a VCPU fd is a good idea. ;)
Regards,
chenwj
--
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj
next prev parent reply other threads:[~2012-06-14 10:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 8:24 [Qemu-devel] Does kvm_fd mean KVM or VCPU fd? 陳韋任 (Wei-Ren Chen)
2012-06-14 9:15 ` Paolo Bonzini
2012-06-14 10:16 ` 陳韋任 (Wei-Ren Chen) [this message]
2012-06-14 14:49 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120614101646.GA18229@cs.nctu.edu.tw \
--to=chenwj@iis.sinica.edu.tw \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.