From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Kees Cook <keescook@chromium.org>
Cc: Per Forlin <per.forlin@stericsson.com>,
linux-kernel@vger.kernel.org, serge.hallyn@canonical.com,
Linus Walleij <linus.walleij@linaro.org>,
Per Forlin <per.lkml@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] reboot: disable nonboot CPUs
Date: Fri, 15 Jun 2012 01:48:34 +0400 [thread overview]
Message-ID: <20120614214834.GB14301@moon> (raw)
In-Reply-To: <CAGXu5jKqaddf3T+LMS-6VMgH98JbMG-NsjB8uajNw19R7OAfig@mail.gmail.com>
On Thu, Jun 14, 2012 at 02:41:48PM -0700, Kees Cook wrote:
> On Thu, Jun 14, 2012 at 2:25 PM, Per Forlin <per.forlin@stericsson.com> wrote:
> > Disable the nonboot CPUs to safely migrate tasks and interrupts
> > to the boot CPU. This will prevent the nonboot CPUs to
> > interfer or block the boot CPU from being able to reboot
> > the system successfully.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> This seems reasonable to me, though I haven't looked too deeply at the
> reboot path.
Looks reasonable to me as well, but better to add some more CC,
since syscore_shutdown seems to call for generic irqs to shutdown
when cpu get turned off already, not sure if this have any side
effect and/or I've missed something (Thomas CC'ed).
Cyrill
next prev parent reply other threads:[~2012-06-14 21:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 21:25 [PATCH] reboot: disable nonboot CPUs Per Forlin
2012-06-14 21:41 ` Kees Cook
2012-06-14 21:48 ` Cyrill Gorcunov [this message]
2012-06-22 20:57 ` Andrew Morton
2012-06-22 21:13 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120614214834.GB14301@moon \
--to=gorcunov@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=per.forlin@stericsson.com \
--cc=per.lkml@gmail.com \
--cc=serge.hallyn@canonical.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.