All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Bowler <nbowler@elliptictech.com>
To: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@kernel.dk>, LKML <linux-kernel@vger.kernel.org>,
	linux-scsi@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
	James Bottomley <JBottomley@parallels.com>
Subject: Re: [PATCH] scsi: Silence unnecessary warnings about ioctl to partition
Date: Fri, 15 Jun 2012 10:31:06 -0400	[thread overview]
Message-ID: <20120615143106.GA16540@elliptictech.com> (raw)
In-Reply-To: <20120615142303.GB19045@quack.suse.cz>

On 2012-06-15 16:23 +0200, Jan Kara wrote:
> On Fri 15-06-12 09:58:25, Nick Bowler wrote:
> > On 2012-06-15 12:51 +0200, Jens Axboe wrote:
> > > On 06/15/2012 12:50 PM, Jan Kara wrote:
> > > > Sometimes, warnings about ioctls to partition happen often enough that they
> > > > form majority of the warnings in the kernel log and users complain. In some
> > > > cases warnings are about ioctls such as SG_IO so it's not good to get rid of
> > > > the warnings completely as they can ease debugging of userspace problems
> > > > when ioctl is refused.
> > > > 
> > > > Since I have seen warnings from lots of commands, including some proprietary
> > > > userspace applications, I don't think disallowing the ioctls for processes
> > > > with CAP_SYS_RAWIO will happen in the near future if ever. So lets just
> > > > stop warning for processes with CAP_SYS_RAWIO for which ioctl is allowed.
> > > 
> > > Agree, merged, finally.
> > 
> > Hurray!
> > 
> > This should be -stable material as well, as >=3.2.y kernel versions are
> > affected (I think 3.0.y is OK?).
>   3.0 also spits those warnings. But I'm not convinced this is really a
> -stable material. I don't see anybody loosing sleep over this...

These messages are quite annoying on my raid boxes (currently running
3.2.y) where mdadm spews a whole pile of these whenever you do anything.

Even with the rate limiting, they make up a substantial proportion of
the total log messages.

Cheers,
-- 
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)


  reply	other threads:[~2012-06-15 14:31 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-15 10:50 [PATCH] scsi: Silence unnecessary warnings about ioctl to partition Jan Kara
2012-06-15 10:50 ` Jan Kara
2012-06-15 10:51 ` Jens Axboe
2012-06-15 13:58   ` Nick Bowler
2012-06-15 14:22     ` Paolo Bonzini
2012-06-15 14:23     ` Jan Kara
2012-06-15 14:31       ` Nick Bowler [this message]
2012-06-15 11:00 ` Alan Cox
  -- strict thread matches above, loose matches on Subject: below --
2012-05-02 10:10 Jan Kara
2012-05-02 10:10 ` Jan Kara
2012-05-02 10:15 ` Paolo Bonzini
2012-05-02 10:37   ` Jens Axboe
2012-05-02 10:54   ` Alan Cox
2012-05-02 11:02     ` Paolo Bonzini
2012-05-02 11:12       ` Alan Cox
2012-05-02 11:24         ` Paolo Bonzini
2012-05-02 12:05           ` Alan Cox
2012-05-02 12:23             ` Paolo Bonzini
2012-05-02 19:38           ` Mark Lord
2012-05-03  7:47             ` Paolo Bonzini
2012-05-03 12:40               ` Mark Lord
2012-05-03 12:47                 ` Paolo Bonzini
2012-05-03 17:36                   ` Mark Lord
2012-05-04  6:39                     ` Paolo Bonzini
2012-05-04 13:06                       ` Mark Lord
2012-05-04 13:08                         ` Paolo Bonzini
2012-05-04 13:11                         ` Mark Lord
2012-05-04 13:24                           ` Mark Lord
2012-05-02 13:51   ` Jan Kara
2012-05-02 13:59     ` Paolo Bonzini
2012-05-02 15:10       ` Alan Cox
2012-05-02 15:49         ` Paolo Bonzini
2012-05-02 20:49           ` Paolo Bonzini
2012-05-02 19:49       ` Jan Kara
2012-05-02 21:16         ` Paolo Bonzini
2012-06-15  8:14 ` Paolo Bonzini
2012-06-15  8:46   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120615143106.GA16540@elliptictech.com \
    --to=nbowler@elliptictech.com \
    --cc=JBottomley@parallels.com \
    --cc=axboe@kernel.dk \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.