diff for duplicates of <20120615223403.GB7357@linux-sh.org> diff --git a/a/1.txt b/N1/1.txt index ef1210f..0d4ef3f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,7 +6,7 @@ On Fri, Jun 15, 2012 at 12:35:18PM -0600, Grant Likely wrote: > > + */ > > +void irq_domain_dispose_mappings(struct irq_domain *domain) > > +{ -> > + if (domain->revmap_type = IRQ_DOMAIN_MAP_NOMAP) +> > + if (domain->revmap_type == IRQ_DOMAIN_MAP_NOMAP) > > + return; > > + > > + if (domain->linear_size) { @@ -35,7 +35,7 @@ for a domain to have multiple linear ranges? > Nit; while not 'while(1)'? > Personal taste, though really it's probably better to just do a -do { ... } while (nr_found = IRQ_DOMAIN_BATCH_IRQS), which will save an +do { ... } while (nr_found == IRQ_DOMAIN_BATCH_IRQS), which will save an iteration when we've run out of tree. > > + int i; diff --git a/a/content_digest b/N1/content_digest index 126fd9e..92a2734 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020120615183518.514853E0ACE@localhost\0" "From\0Paul Mundt <lethal@linux-sh.org>\0" "Subject\0Re: [PATCH 2/2] irqdomain: Support one-shot tear down of domain mappings.\0" - "Date\0Fri, 15 Jun 2012 22:34:03 +0000\0" + "Date\0Sat, 16 Jun 2012 07:34:03 +0900\0" "To\0Grant Likely <grant.likely@secretlab.ca>\0" "Cc\0linux-sh@vger.kernel.org" " linux-kernel@vger.kernel.org\0" @@ -17,7 +17,7 @@ "> > + */\n" "> > +void irq_domain_dispose_mappings(struct irq_domain *domain)\n" "> > +{\n" - "> > +\tif (domain->revmap_type = IRQ_DOMAIN_MAP_NOMAP)\n" + "> > +\tif (domain->revmap_type == IRQ_DOMAIN_MAP_NOMAP)\n" "> > +\t\treturn;\n" "> > +\n" "> > +\tif (domain->linear_size) {\n" @@ -46,7 +46,7 @@ "> Nit; while not 'while(1)'?\n" "> \n" "Personal taste, though really it's probably better to just do a\n" - "do { ... } while (nr_found = IRQ_DOMAIN_BATCH_IRQS), which will save an\n" + "do { ... } while (nr_found == IRQ_DOMAIN_BATCH_IRQS), which will save an\n" "iteration when we've run out of tree.\n" "\n" "> > +\t\t\tint i;\n" @@ -75,4 +75,4 @@ "\n" I'll respin with the above rework. -57683ade9542cf5a64850e786b71dfb2e51d939fdb5cfd209cb86a28462af197 +cda9cedcc26c5ed63ac321d3a0e0d86683d7dcd01d1799a45073cc084b9caaff
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.