From: Josh Triplett <josh@joshtriplett.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, Valdis.Kletnieks@vt.edu,
dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com,
fweisbec@gmail.com, patches@linaro.org,
"Paul E. McKenney" <paul.mckenney@linaro.org>
Subject: Re: [PATCH tip/core/rcu 14/14] rcu: Fix rcu_is_cpu_idle() #ifdef in TINY_RCU
Date: Fri, 15 Jun 2012 16:05:07 -0700 [thread overview]
Message-ID: <20120615230507.GA7554@leaf> (raw)
In-Reply-To: <20120615225749.GQ2389@linux.vnet.ibm.com>
On Fri, Jun 15, 2012 at 03:57:49PM -0700, Paul E. McKenney wrote:
> On Fri, Jun 15, 2012 at 02:28:28PM -0700, Josh Triplett wrote:
> > On Fri, Jun 15, 2012 at 01:13:15PM -0700, Paul E. McKenney wrote:
> > > From: "Paul E. McKenney" <paul.mckenney@linaro.org>
> > >
> > > The rcu_is_cpu_idle() function is used if CONFIG_DEBUG_LOCK_ALLOC,
> > > but TINY_RCU defines it only when CONFIG_PROVE_RCU. This causes
> > > build failures when CONFIG_DEBUG_LOCK_ALLOC=y but CONFIG_PROVE_RCU=n.
> > > This commit therefore adjusts the #ifdefs for rcu_is_cpu_idle() so
> > > that it is defined when CONFIG_DEBUG_LOCK_ALLOC=y.
> > >
> > > Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
> > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> >
> > Given that an earlier patch in this series makes rcupdate.h
> > unconditionally prototype rcu_is_cpu_idle, shouldn't rcutiny.c define it
> > unconditionally? (And do so before the earlier patch in this series
> > makes it available unconditionally?)
>
> Or update that earlier patch so that it keeps rcu_is_cpu_idle() under
> #ifdef CONFIG_DEBUG_LOCK_ALLOC. Either way, good catch!
>
> Hmmm... I want it under CONFIG_DEBUG_LOCK_ALLOC for TINY_RCU (memory
> footprint and all that), but unconditional for TREE_RCU. That can
> be arranged...
Seems reasonable to me, as long as the availability of the prototype at
compile time always matches the availability of the function at link
time.
- Josh Triplett
next prev parent reply other threads:[~2012-06-15 23:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 20:12 [PATCH tip/core/rcu 0/14] Fixups for 3.6 Paul E. McKenney
2012-06-15 20:13 ` [PATCH tip/core/rcu 01/14] rcu: Fix detection of abruptly-ending stall Paul E. McKenney
2012-06-15 20:13 ` [PATCH tip/core/rcu 02/14] rcu: Consolidate duplicate callback-list initialization Paul E. McKenney
2012-06-15 20:42 ` Josh Triplett
2012-06-15 20:13 ` [PATCH tip/core/rcu 03/14] rcu: Add ACCESS_ONCE() to ->qlen accesses Paul E. McKenney
2012-06-15 20:45 ` Josh Triplett
2012-06-15 22:24 ` Paul E. McKenney
2012-06-15 20:13 ` [PATCH tip/core/rcu 04/14] rcu: Add a gcc-style structure initializer for RCU pointers Paul E. McKenney
2012-06-15 20:48 ` Josh Triplett
2012-06-15 21:22 ` Paul E. McKenney
2012-06-15 21:50 ` Josh Triplett
2012-06-15 22:47 ` Paul E. McKenney
2012-06-15 20:13 ` [PATCH tip/core/rcu 05/14] rcu: Use new INIT_RCU_POINTER for gcc-style initializations Paul E. McKenney
2012-06-15 20:13 ` [PATCH tip/core/rcu 06/14] rcu: Remove return value from RCU_INIT_POINTER() Paul E. McKenney
2012-06-15 20:50 ` Josh Triplett
2012-06-15 20:13 ` [PATCH tip/core/rcu 07/14] key: Remove extraneous parentheses from rcu_assign_keypointer() Paul E. McKenney
2012-06-15 20:50 ` Josh Triplett
2012-06-15 20:13 ` [PATCH tip/core/rcu 08/14] rcu: Remove return value from rcu_assign_pointer() Paul E. McKenney
2012-06-15 20:53 ` Josh Triplett
2012-06-15 20:13 ` [PATCH tip/core/rcu 09/14] rcu: Consolidate tree/tiny __rcu_read_{,un}lock() implementations Paul E. McKenney
2012-06-15 20:59 ` Josh Triplett
2012-06-15 20:13 ` [PATCH tip/core/rcu 10/14] rcu: Remove function versions of __kfree_rcu and __is_kfree_rcu_offset Paul E. McKenney
2012-06-15 20:59 ` Josh Triplett
2012-06-15 20:13 ` [PATCH tip/core/rcu 11/14] rcu: Make __call_rcu() handle invocation from idle Paul E. McKenney
2012-06-15 21:02 ` Josh Triplett
2012-06-15 20:13 ` [PATCH tip/core/rcu 12/14] rcu: Prevent __call_rcu() from invoking RCU core on offline CPUs Paul E. McKenney
2012-06-15 21:04 ` Josh Triplett
2012-06-15 20:13 ` [PATCH tip/core/rcu 13/14] rcu: Split RCU core processing out of __call_rcu() Paul E. McKenney
2012-06-15 21:25 ` Josh Triplett
2012-06-15 20:13 ` [PATCH tip/core/rcu 14/14] rcu: Fix rcu_is_cpu_idle() #ifdef in TINY_RCU Paul E. McKenney
2012-06-15 21:28 ` Josh Triplett
2012-06-15 22:57 ` Paul E. McKenney
2012-06-15 23:05 ` Josh Triplett [this message]
2012-06-15 20:40 ` [PATCH tip/core/rcu 01/14] rcu: Fix detection of abruptly-ending stall Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120615230507.GA7554@leaf \
--to=josh@joshtriplett.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=darren@dvhart.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=niv@us.ibm.com \
--cc=patches@linaro.org \
--cc=paul.mckenney@linaro.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.