All of lore.kernel.org
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mx23: Add initial support for olinuxino board
Date: Sun, 17 Jun 2012 15:02:42 +0200	[thread overview]
Message-ID: <20120617130242.GA28394@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5AOiaUqbiOS6e40v=jHJ2U3Dit2D5b8_2OZnEeV-A_Ong@mail.gmail.com>

On Sun, Jun 17, 2012 at 09:59:18AM -0300, Fabio Estevam wrote:
> On Sun, Jun 17, 2012 at 9:41 AM, Fabio Estevam <festevam@gmail.com> wrote:
> > On Sun, Jun 17, 2012 at 8:14 AM, Marek Vasut <marex@denx.de> wrote:
> >
> >>> ?static const char *imx23_dt_compat[] __initdata = {
> >>> ? ? ? "fsl,imx23-evk",
> >>> + ? ? "fsl,imx23-olinuxino",
> >>
> >> Is this addition needed?
> >
> > Actually it is not required. Board boots just fine without it.
> >
> > I have just kept this for compatibilty with other i.MX boards boards
> > added to dt.
> >
> > I followed the same approach from imx6q_dt_compat and imx53_dt_compat.
> 
> I would prefer to do something like that instead:
> 
> static const char *<soc>_dt_compat[] __initdata = {
> 	"fsl,<soc>",
> 	NULL,
> }
> 
> ,this way we do not have to patch a C file when adding a new board file.
> 

There already is a fsl,imx23 compatible entry, you just have to use it.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2012-06-17 13:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-17  6:28 [PATCH] ARM: mx23: Add initial support for olinuxino board Fabio Estevam
2012-06-17 11:14 ` Marek Vasut
2012-06-17 12:41   ` Fabio Estevam
2012-06-17 12:59     ` Fabio Estevam
2012-06-17 13:02       ` Sascha Hauer [this message]
2012-06-18 13:18   ` Shawn Guo
2012-06-18 13:27 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120617130242.GA28394@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.