From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: ux500: bump i2c bus speed to 400kHz
Date: Mon, 18 Jun 2012 01:06:20 +0200 [thread overview]
Message-ID: <201206180106.21108.marek.vasut@gmail.com> (raw)
In-Reply-To: <1339955837-26691-1-git-send-email-linus.walleij@stericsson.com>
Dear Linus Walleij,
> From: Linus Walleij <linus.walleij@linaro.org>
>
> Some recent discussion revealed inconsistency in the board file
> for the MOP500 family. The board can very well do 400kHz on
> the I2C busses, so make it do that.
Shouldn't this be controlled by DT? Some of the i2c devices can't do 400kHz.
> Cc: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> arch/arm/mach-ux500/board-mop500.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-ux500/board-mop500.c
> b/arch/arm/mach-ux500/board-mop500.c index 9c74ac5..e441bd7 100644
> --- a/arch/arm/mach-ux500/board-mop500.c
> +++ b/arch/arm/mach-ux500/board-mop500.c
> @@ -354,13 +354,13 @@ static struct nmk_i2c_controller u8500_i2c##id##_data
> = { \ /*
> * The board uses 4 i2c controllers, initialize all of
> * them with slave data setup time of 250 ns,
> - * Tx & Rx FIFO threshold values as 8 and standard
> + * Tx & Rx FIFO threshold values as 1 resp. 8 and fast
> * mode of operation
> */
> -U8500_I2C_CONTROLLER(0, 0xe, 1, 8, 100000, 200, I2C_FREQ_MODE_FAST);
> -U8500_I2C_CONTROLLER(1, 0xe, 1, 8, 100000, 200, I2C_FREQ_MODE_FAST);
> -U8500_I2C_CONTROLLER(2, 0xe, 1, 8, 100000, 200, I2C_FREQ_MODE_FAST);
> -U8500_I2C_CONTROLLER(3, 0xe, 1, 8, 100000, 200, I2C_FREQ_MODE_FAST);
> +U8500_I2C_CONTROLLER(0, 0xe, 1, 8, 400000, 200, I2C_FREQ_MODE_FAST);
> +U8500_I2C_CONTROLLER(1, 0xe, 1, 8, 400000, 200, I2C_FREQ_MODE_FAST);
> +U8500_I2C_CONTROLLER(2, 0xe, 1, 8, 400000, 200, I2C_FREQ_MODE_FAST);
> +U8500_I2C_CONTROLLER(3, 0xe, 1, 8, 400000, 200, I2C_FREQ_MODE_FAST);
>
> static void __init mop500_i2c_init(struct device *parent)
> {
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-06-17 23:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-17 17:57 [PATCH] ARM: ux500: bump i2c bus speed to 400kHz Linus Walleij
2012-06-17 23:06 ` Marek Vasut [this message]
2012-06-18 6:01 ` Linus Walleij
2012-06-18 11:28 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206180106.21108.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.