From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 92/95] hwmon: (smsc47m1) Convert to use devm_ functions
Date: Mon, 18 Jun 2012 02:07:04 +0000 [thread overview]
Message-ID: <20120618020704.GA17389@ericsson.com> (raw)
In-Reply-To: <1339773856-3443-93-git-send-email-linux@roeck-us.net>
On Sun, Jun 17, 2012 at 04:57:05PM -0400, Jean Delvare wrote:
> On Fri, 15 Jun 2012 08:24:13 -0700, Guenter Roeck wrote:
> > Convert to use devm_ functions to reduce code size and simplify the code.
> >
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > drivers/hwmon/smsc47m1.c | 40 ++++++++--------------------------------
> > 1 file changed, 8 insertions(+), 32 deletions(-)
> >
> > diff --git a/drivers/hwmon/smsc47m1.c b/drivers/hwmon/smsc47m1.c
> > index b5aa38d..b3a38af 100644
> > --- a/drivers/hwmon/smsc47m1.c
> > +++ b/drivers/hwmon/smsc47m1.c
> > @@ -584,13 +584,11 @@ static void smsc47m1_restore(const struct smsc47m1_sio_data *sio_data)
> >
> > #define CHECK 1
> > #define REQUEST 2
> > -#define RELEASE 3
> >
> > /*
> > * This function can be used to:
> > * - test for resource conflicts with ACPI
> > * - request the resources
> > - * - release the resources
> > * We only allocate the I/O ports we really need, to minimize the risk of
> > * conflicts with ACPI or with other drivers.
> > */
> > @@ -642,21 +640,13 @@ static int smsc47m1_handle_resources(unsigned short address, enum chips type,
>
> This function can now be marked __init.
>
Done.
> Other than this, I have no issue with the patch.
>
> Acked-by: Jean Delvare <khali@linux-fr.org>
>
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2012-06-18 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 15:24 [lm-sensors] [PATCH 92/95] hwmon: (smsc47m1) Convert to use devm_ functions Guenter Roeck
2012-06-17 20:57 ` Jean Delvare
2012-06-18 2:07 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120618020704.GA17389@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.