From: Oliver Neukum <oneukum-l3A5Bk7waGM@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: huajun.li.lee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
tom.leiming-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] usbnet: Activate halt interrupt endpoint before re-submit URB
Date: Mon, 18 Jun 2012 09:23:36 +0200 [thread overview]
Message-ID: <201206180923.36091.oneukum@suse.de> (raw)
In-Reply-To: <20120617.163017.1067800063889498786.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Am Montag, 18. Juni 2012, 01:30:17 schrieb David Miller:
> From: Huajun Li <huajun.li.lee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date: Wed, 13 Jun 2012 20:50:31 +0800
>
> > intr_complete() submits URB even the interrupt endpoint stalls.
> > This patch will try to activate the endpoint once the exception
> > occurs, and then re-submit the URB if the endpoint works again.
> >
> > Signed-off-by: Huajun Li <huajun.li.lee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Review from USB experts would be appreciated.
The code implements a minimum error handler correctly.
Did you observe a stall in actual hardware or is this a just
in case patch?
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-06-18 7:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 12:50 [PATCH] usbnet: Activate halt interrupt endpoint before re-submit URB Huajun Li
2012-06-17 23:30 ` David Miller
[not found] ` <20120617.163017.1067800063889498786.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-06-18 7:23 ` Oliver Neukum [this message]
[not found] ` <201206180923.36091.oneukum-l3A5Bk7waGM@public.gmane.org>
2012-06-18 16:25 ` Huajun Li
[not found] ` <CA+v9cxZG6b1O7kOQpeTELtv0vHzqy-8NH84boMpim0BM+tp1eQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-18 16:51 ` Oliver Neukum
[not found] ` <201206181851.49765.oneukum-l3A5Bk7waGM@public.gmane.org>
2012-06-19 15:50 ` Ming Lei
2012-06-20 8:00 ` Oliver Neukum
[not found] ` <201206201000.21845.oneukum-l3A5Bk7waGM@public.gmane.org>
2012-06-20 8:07 ` Ming Lei
2012-06-20 8:58 ` Oliver Neukum
[not found] ` <201206201058.55519.oneukum-l3A5Bk7waGM@public.gmane.org>
2012-06-20 10:15 ` Ming Lei
2012-06-20 10:21 ` Oliver Neukum
2012-06-20 10:56 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206180923.36091.oneukum@suse.de \
--to=oneukum-l3a5bk7wagm@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=huajun.li.lee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=tom.leiming-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.