From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [RFC PATCH] kvm: Extend irqfd to support level interrupts Date: Mon, 18 Jun 2012 13:55:04 +0300 Message-ID: <20120618105504.GA24051@redhat.com> References: <20120616163230.15204.61075.stgit@bling.home> <4FDEE0A3.80900@redhat.com> <4FDEEC52.8080806@siemens.com> <4FDEF5CD.8090806@redhat.com> <20120618101156.GB23134@redhat.com> <4FDEFF75.6060104@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kiszka , Alex Williamson , "mtosatti@redhat.com" , "kvm@vger.kernel.org" To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:28356 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750914Ab2FRKzK (ORCPT ); Mon, 18 Jun 2012 06:55:10 -0400 Content-Disposition: inline In-Reply-To: <4FDEFF75.6060104@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jun 18, 2012 at 01:14:13PM +0300, Avi Kivity wrote: > On 06/18/2012 01:11 PM, Michael S. Tsirkin wrote: > > >> (vhost, > >> msi-less ivshmem clone)? > > > > I guess vhost can poll eventfd and reinject an interrupt. > > Of course to bypass qemu completely we also need to support reads over > > ioeventfd somehow. > > > > eventfd is not suitable for level triggered interrupts as far as I can > tell. It's about passing edges, and level interrupts aren't. We need > something like a pipe for communicating state (or just use KVM_IRQ_LINE). Just using KVM_IRQ_LINE won't be enough. There's no software event when device deasserts the line, and no stadard way for drivers to do this. So kvm needs to trigger on some event to poll the real interrupt state, to check whether it's ok to clear for the guest, and forward it to userspace. > -- > error compiling committee.c: too many arguments to function >