On Mon, Jun 18, 2012 at 08:29:45PM +0900, Sangbeom Kim wrote: > -struct sec_irq_data { > - int reg; > - int mask; > +static struct sec_irq_data s2mps11_irqs[] = { > + [S2MPS11_IRQ_PWRONF] = { > + .reg = 1, > + .mask = S2MPS11_IRQ_PWRONF_MASK, > + }, This looks like you should be able to factor this code out into regmap_irq? Might be worth doing that first before all the renames so that adding the new PMIC would just be adding some more data.