From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v6 6/9] KVM: MMU: fast path of handling guest page fault Date: Mon, 18 Jun 2012 16:21:20 -0300 Message-ID: <20120618192120.GA2697@amt.cnet> References: <4FC470C7.5040700@linux.vnet.ibm.com> <4FC471B8.3070204@linux.vnet.ibm.com> <20120613224002.GE19290@amt.cnet> <20120614102214.1c8a6e23.yoshikawa.takuya@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Xiao Guangrong , Avi Kivity , LKML , KVM To: Takuya Yoshikawa Return-path: Content-Disposition: inline In-Reply-To: <20120614102214.1c8a6e23.yoshikawa.takuya@oss.ntt.co.jp> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Thu, Jun 14, 2012 at 10:22:14AM +0900, Takuya Yoshikawa wrote: > On Wed, 13 Jun 2012 19:40:02 -0300 > Marcelo Tosatti wrote: > > > mmu_spte_update is handling several different cases. Please rewrite > > it, add a comment on top of it (or spread comments on top of each > > significant code line) with all cases it is handling (also recheck it > > regarding new EPT accessed/dirty bits code). > > [not about this patch] > > EPT accessed/dirty bits will be used for more things in the future. > Are there any rules for using these bits? > > Same as other bits? Do you mean hardware rules or KVM rules?