From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/9] xfs: separate buffer indexing from block map
Date: Mon, 18 Jun 2012 15:39:19 -0500 [thread overview]
Message-ID: <20120618203919.GW4721@sgi.com> (raw)
In-Reply-To: <1339133914-11148-2-git-send-email-david@fromorbit.com>
Hi Dave,
On Fri, Jun 08, 2012 at 03:38:26PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> To support discontiguous buffers in the buffer cache, we need to
> separate the cache index variables from the I/O map. While this is
> currently a 1:1 mapping, discontiguous buffer support will break
> this relationship.
>
> However, for caching purposes, we can still treat them the same as a
> contiguous buffer - the block number of the first block and the
> length of the buffer - as that is still a unique representation.
> Also, the only way we will ever access the discontiguous regions of
> buffers is via bulding the complete buffer in the first place, so
> using the initial block number and entire buffer length is a sane
> way to index the buffers.
>
> Add a block mapping vector construct to the xfs_buf and use it in
> the places where we are doing IO instead of the current
> b_bn/b_length variables.
This patch does not apply even with Jan's patch. Merged it manually.
-Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-06-18 20:38 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 5:38 [PATCH 0/9] xfs: discontiguous directory buffer support Dave Chinner
2012-06-08 5:38 ` [PATCH 1/9] xfs: separate buffer indexing from block map Dave Chinner
2012-06-18 20:39 ` Ben Myers [this message]
2012-06-20 6:44 ` Christoph Hellwig
2012-06-20 7:36 ` Dave Chinner
2012-06-08 5:38 ` [PATCH 2/9] xfs: convert internal buffer functions to pass maps Dave Chinner
2012-06-18 20:43 ` Ben Myers
2012-06-18 21:07 ` Ben Myers
2012-06-19 7:15 ` Christoph Hellwig
2012-06-19 15:59 ` Ben Myers
2012-06-19 17:03 ` Christoph Hellwig
2012-06-19 17:11 ` Ben Myers
2012-06-20 5:56 ` Dave Chinner
2012-06-20 6:04 ` Christoph Hellwig
2012-06-20 6:29 ` Dave Chinner
2012-06-20 6:46 ` Dave Chinner
2012-06-20 15:39 ` Ben Myers
2012-06-20 15:36 ` Ben Myers
2012-06-20 23:04 ` Dave Chinner
2012-06-20 6:35 ` Dave Chinner
2012-06-20 15:48 ` Ben Myers
2012-06-20 6:29 ` Christoph Hellwig
2012-06-20 6:37 ` Dave Chinner
2012-06-20 15:51 ` Ben Myers
2012-06-20 6:48 ` Christoph Hellwig
2012-06-22 6:48 ` Dave Chinner
2012-06-08 5:38 ` [PATCH 3/9] xfs: add discontiguous buffer map interface Dave Chinner
2012-06-20 6:53 ` Christoph Hellwig
2012-06-08 5:38 ` [PATCH 4/9] xfs: add discontiguous buffer support to transactions Dave Chinner
2012-06-20 6:54 ` Christoph Hellwig
2012-06-08 5:38 ` [PATCH 5/9] xfs: struct xfs_buf_log_format isn't variable sized Dave Chinner
2012-06-20 6:36 ` Christoph Hellwig
2012-06-20 7:01 ` Dave Chinner
2012-06-20 7:05 ` Christoph Hellwig
2012-06-08 5:38 ` [PATCH 6/9] xfs: support discontiguous buffers in the xfs_buf_log_item Dave Chinner
2012-06-20 7:15 ` Christoph Hellwig
2012-06-08 5:38 ` [PATCH 7/9] xfs: use multiple irec xfs buf support in dabuf Dave Chinner
2012-06-20 7:18 ` Christoph Hellwig
2012-06-08 5:38 ` [PATCH 8/9] xfs: remove struct xfs_dabuf and infrastructure Dave Chinner
2012-06-20 7:20 ` Christoph Hellwig
2012-06-08 5:38 ` [PATCH 9/9] xfs: factor buffer reading from xfs_dir2_leaf_getdents Dave Chinner
2012-06-20 7:27 ` Christoph Hellwig
2012-06-20 7:41 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120618203919.GW4721@sgi.com \
--to=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.