From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH UPDATED] block: In blk_execute_rq_nowait, init rq->end_io before checking for dead queue. Date: Mon, 18 Jun 2012 15:42:53 -0700 Message-ID: <20120618224253.GH32733@google.com> References: <4FD345DC.6020405@acm.org> <4FD4DC26.5080902@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Muthu Kumar Cc: Bart Van Assche , Jens Axboe , Jej B , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On Mon, Jun 11, 2012 at 02:23:23PM -0700, Muthu Kumar wrote: > On Mon, Jun 11, 2012 at 10:33 AM, Muthu Kumar wrote: > > On Sun, Jun 10, 2012 at 10:40 AM, Bart Van Assche wrote: > >> On 06/09/12 23:57, Muthu Kumar wrote: > >> > >>> Locking change is the one you posted already (the link above). Anyway, > >>> I have the attached patch *including* the locking change. Original > >>> mail has attachment without locking change. Please use whatever you > >>> need. > >> > >> > >> While we are at it ... the rq->rq_disk and rq->end_io assignments can be > >> performed safely before the spinlock is taken, isn't it ? > >> > > > > Yes.. that spinlock is to protect the q. > > > > Attached patch with assignment performed before taking the spinlock. This looks correct to me. Bart, can you please include this patch in your series and repost the series? Thank you. -- tejun