All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	devel@driverdev.osuosl.org, abbotti@mev.co.uk,
	fmhess@users.sourceforge.net
Subject: Re: [PATCH 1/4] staging: comedi: Kconfig: menuconfig options should be bool not tristate
Date: Mon, 18 Jun 2012 16:59:02 -0700	[thread overview]
Message-ID: <20120618235902.GA29679@kroah.com> (raw)
In-Reply-To: <201206151520.04455.hartleys@visionengravers.com>

On Fri, Jun 15, 2012 at 03:20:04PM -0700, H Hartley Sweeten wrote:
> The menuconfig options to enable the misc, isa, pci, pcmcia, and usb
> comedi driver selections should be bool not tristate. They don't
> directly affect the building of the kernel they just allow other
> options to be selected.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ian Abbott <abbotti@mev.co.uk>
> Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
> ---
>  drivers/staging/comedi/Kconfig |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)

This patch breaks the build for me with lots of the following errors:
ERROR: "subdev_8255_init" [drivers/staging/comedi/drivers/adl_pci7296.ko] undefined!
ERROR: "subdev_8255_cleanup" [drivers/staging/comedi/drivers/adl_pci7296.ko] undefined!

So I can't take it, or the other 4 patches in this series, sorry.

Care to redo it?

thanks,

greg k-h

  reply	other threads:[~2012-06-18 23:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-15 22:20 [PATCH 1/4] staging: comedi: Kconfig: menuconfig options should be bool not tristate H Hartley Sweeten
2012-06-18 23:59 ` Greg KH [this message]
2012-06-19  0:01   ` H Hartley Sweeten
2012-06-19  0:16   ` H Hartley Sweeten
2012-06-19  0:30     ` Greg KH
2012-06-19  1:01       ` H Hartley Sweeten
2012-06-19  8:35         ` Ian Abbott
2012-06-19 16:32           ` H Hartley Sweeten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120618235902.GA29679@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=fmhess@users.sourceforge.net \
    --cc=hartleys@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.