From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
devel@driverdev.osuosl.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 02/10] iio: Add helper function for initializing triggered buffers
Date: Mon, 18 Jun 2012 17:28:18 -0700 [thread overview]
Message-ID: <20120619002818.GA20240@kroah.com> (raw)
In-Reply-To: <1340037236-15685-2-git-send-email-lars@metafoo.de>
On Mon, Jun 18, 2012 at 06:33:48PM +0200, Lars-Peter Clausen wrote:
> --- a/drivers/iio/Makefile
> +++ b/drivers/iio/Makefile
> @@ -7,6 +7,7 @@ industrialio-y := industrialio-core.o industrialio-event.o inkern.o
> industrialio-$(CONFIG_IIO_BUFFER) += industrialio-buffer.o
> industrialio-$(CONFIG_IIO_TRIGGER) += industrialio-trigger.o
>
> +obj-$(CONFIG_IIO_TRIGGERED_BUFFER) += industrialio-triggered-buffer.o
That's a crazy module name, does it really need to be that big? And in
a separate module?
Anyway, I've taken it, but why can't this just be merged into the iio.ko
main module? Actually, why can't all of these different trigger and
buffer modules be part of the iio module?
> obj-$(CONFIG_IIO_KFIFO_BUF) += kfifo_buf.o
Shouldn't this be iio_kfifo_buf?
thanks,
greg k-h
next prev parent reply other threads:[~2012-06-19 0:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 16:33 [PATCH 01/10] iio: iio_buffer_register: Skip channels with negative scan index Lars-Peter Clausen
2012-06-18 16:33 ` [PATCH 02/10] iio: Add helper function for initializing triggered buffers Lars-Peter Clausen
2012-06-19 0:28 ` Greg Kroah-Hartman [this message]
2012-06-19 7:17 ` Jonathan Cameron
2012-06-18 16:33 ` [PATCH 03/10] iio:adc:at91: Use new triggered buffer setup helper Lars-Peter Clausen
2012-06-18 16:33 ` [PATCH 04/10] staging:iio:adc:ad7192: Use new triggered buffer setup helper function Lars-Peter Clausen
2012-06-18 16:33 ` [PATCH 05/10] staging:iio:adc:ad7298: " Lars-Peter Clausen
2012-06-18 16:33 ` [PATCH 06/10] staging:iio:adc:ad7476: " Lars-Peter Clausen
2012-06-18 16:33 ` [PATCH 07/10] staging:iio:adc:ad7606: " Lars-Peter Clausen
2012-06-18 16:33 ` [PATCH 08/10] staging:iio:adc:ad7793: " Lars-Peter Clausen
2012-06-18 16:33 ` [PATCH 09/10] staging:iio:adc:ad7887: " Lars-Peter Clausen
2012-06-18 16:33 ` [PATCH 10/10] staging:iio:adc:ad799x: " Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120619002818.GA20240@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.