All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: tinguely@sgi.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2 v2] xfs: rename log structure and remove xlog_t typedef.
Date: Tue, 19 Jun 2012 03:45:05 -0400	[thread overview]
Message-ID: <20120619074505.GA30375@infradead.org> (raw)
In-Reply-To: <20120614142430.963813265@sgi.com>

On Thu, Jun 14, 2012 at 09:22:15AM -0500, tinguely@sgi.com wrote:
> From: Mark Tinguely <tinguely@sgi.com>
> 
> Rename the XFS log structure to xlog to help crash distinquish it from the
> other logs in Linux.

Please don't use the same subject for two patches, instead this one
should be some thing like

	xfs: rename struct log to struct xlog

and the next one

	xfs: remove the xlog_t typedef

otherwise both patches look fine to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-06-19  7:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-14 14:22 [PATCH 0/2 v2] Subject xfs: rename log structure and remove xlog_t typedef tinguely
2012-06-14 14:22 ` [PATCH 1/2 v2] " tinguely
2012-06-19  7:45   ` Christoph Hellwig [this message]
2012-06-21 15:32   ` Ben Myers
2012-06-14 14:22 ` [PATCH 2/2 " tinguely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120619074505.GA30375@infradead.org \
    --to=hch@infradead.org \
    --cc=tinguely@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.