From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 19 Jun 2012 11:31:36 +0200 (CEST) Received: from mail1.windriver.com ([147.11.146.13]:38255 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903394Ab2FSJb3 (ORCPT ); Tue, 19 Jun 2012 11:31:29 +0200 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca [147.11.189.40]) by mail1.windriver.com (8.14.3/8.14.3) with ESMTP id q5J9VG55026654 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 19 Jun 2012 02:31:16 -0700 (PDT) Received: from localhost (128.224.162.203) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.1.255.0; Tue, 19 Jun 2012 02:31:16 -0700 Date: Tue, 19 Jun 2012 17:31:13 +0800 From: Yong Zhang To: Huacai Chen CC: Ralf Baechle , , Fuxin Zhang , Zhangjin Wu , Huacai Chen , Hongliang Tao , Hua Yan Subject: Re: [PATCH V2 15/16] MIPS: Loongson 3: Add CPU Hotplug support. Message-ID: <20120619093113.GB305@windriver.com> Reply-To: Yong Zhang References: <1340088624-25550-1-git-send-email-chenhc@lemote.com> <1340088624-25550-16-git-send-email-chenhc@lemote.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1340088624-25550-16-git-send-email-chenhc@lemote.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [128.224.162.203] X-archive-position: 33711 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: yong.zhang@windriver.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Return-Path: On Tue, Jun 19, 2012 at 02:50:23PM +0800, Huacai Chen wrote: > diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c > index e9a5fd7..69b17a9 100644 > --- a/arch/mips/kernel/process.c > +++ b/arch/mips/kernel/process.c > @@ -72,9 +72,7 @@ void __noreturn cpu_idle(void) > } > } > #ifdef CONFIG_HOTPLUG_CPU > - if (!cpu_online(cpu) && !cpu_isset(cpu, cpu_callin_map) && > - (system_state == SYSTEM_RUNNING || > - system_state == SYSTEM_BOOTING)) > + if (!cpu_online(cpu) && !cpu_isset(cpu, cpu_callin_map)) > play_dead(); I think patch like this should be separated from BSP code. BTW, what's the story behind this change? Thanks, Yong From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail1.windriver.com ([147.11.146.13]:38255 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903394Ab2FSJb3 (ORCPT ); Tue, 19 Jun 2012 11:31:29 +0200 Date: Tue, 19 Jun 2012 17:31:13 +0800 From: Yong Zhang Subject: Re: [PATCH V2 15/16] MIPS: Loongson 3: Add CPU Hotplug support. Message-ID: <20120619093113.GB305@windriver.com> Reply-To: Yong Zhang References: <1340088624-25550-1-git-send-email-chenhc@lemote.com> <1340088624-25550-16-git-send-email-chenhc@lemote.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1340088624-25550-16-git-send-email-chenhc@lemote.com> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: Return-Path: To: Huacai Chen Cc: Ralf Baechle , linux-mips@linux-mips.org, Fuxin Zhang , Zhangjin Wu , Huacai Chen , Hongliang Tao , Hua Yan Message-ID: <20120619093113.IW8A3Zp_pEJvsWUuAKKmrJXRpOwBuNR21nhM5ptymbk@z> On Tue, Jun 19, 2012 at 02:50:23PM +0800, Huacai Chen wrote: > diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c > index e9a5fd7..69b17a9 100644 > --- a/arch/mips/kernel/process.c > +++ b/arch/mips/kernel/process.c > @@ -72,9 +72,7 @@ void __noreturn cpu_idle(void) > } > } > #ifdef CONFIG_HOTPLUG_CPU > - if (!cpu_online(cpu) && !cpu_isset(cpu, cpu_callin_map) && > - (system_state == SYSTEM_RUNNING || > - system_state == SYSTEM_BOOTING)) > + if (!cpu_online(cpu) && !cpu_isset(cpu, cpu_callin_map)) > play_dead(); I think patch like this should be separated from BSP code. BTW, what's the story behind this change? Thanks, Yong