All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Johannes Stezenbach <js@sig21.net>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 0/6] misc ethernet fixes and new driver
Date: Wed, 20 Jun 2012 09:15:35 +0200	[thread overview]
Message-ID: <20120620071535.GH28394@pengutronix.de> (raw)
In-Reply-To: <1340030880-10062-1-git-send-email-js@sig21.net>

On Mon, Jun 18, 2012 at 04:47:54PM +0200, Johannes Stezenbach wrote:
> Hi,
> 
> I ported the designware ethernet driver from u-boot, it
> only required minor changes and worked right away.
> Since my hw has 1G ethernet I added support for this,
> although speed is not so important in a boot loader it seemed
> easier than to reconfigure the PHY for 100Mbit.
> 
> Patches 4 and 5 may be a bit controversial.  The motivation
> for patch 4 is that took me some head scratching to get
> debug read/write on PHY regs correct since md and mw worked
> against my intuition on /dev/phy0.
> The string in eth_set_ethaddr() confused me to think a string
> would be passed to ->set_ethaddr().  Changing "unsigned char *adr"
> to "u8 adr[6]" does not change the generated code but is IMHO
> harder to misunderstand.

I applied this series up to 5/6 for now. Thanks, it's always nice to see code
cleanups.

Sascha

> 
> 
> Johannes
> 
>  drivers/net/Kconfig      |   11 ++
>  drivers/net/Makefile     |    1 +
>  drivers/net/designware.c |  433 ++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/net/designware.h |  230 ++++++++++++++++++++++++
>  drivers/net/miidev.c     |   72 ++++++--
>  include/miidev.h         |    4 +
>  include/net.h            |    8 +-
>  include/net/designware.h |    9 +
>  net/eth.c                |    2 +-
>  net/net.c                |    4 +-
>  10 files changed, 752 insertions(+), 22 deletions(-)
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2012-06-20  7:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18 14:47 [PATCH 0/6] misc ethernet fixes and new driver Johannes Stezenbach
2012-06-18 14:47 ` [PATCH 1/6] miidev: fix auto negotiation Johannes Stezenbach
2012-06-18 17:52   ` Roberto Nibali
2012-06-18 19:26     ` Johannes Stezenbach
2012-06-18 14:47 ` [PATCH 2/6] miidev: actually probe the PHY Johannes Stezenbach
2012-06-18 18:27   ` Roberto Nibali
2012-06-18 19:39     ` Johannes Stezenbach
2012-06-18 14:47 ` [PATCH 3/6] miidev: add support for 1000Mbit Johannes Stezenbach
2012-06-18 14:47 ` [PATCH 4/6] miidev: consistent md and mw on phy regs Johannes Stezenbach
2012-06-20  6:49   ` Sascha Hauer
2012-06-18 14:47 ` [PATCH 5/6] eth: eth MAC addresses are six bytes Johannes Stezenbach
2012-06-18 14:48 ` [PATCH 6/6] drivers/net: add designware driver Johannes Stezenbach
2012-06-20  7:13   ` Sascha Hauer
2012-06-20  8:11     ` Johannes Stezenbach
2012-06-20  8:41       ` Sascha Hauer
2012-06-20  7:15 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120620071535.GH28394@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=js@sig21.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.