diff for duplicates of <20120620074447.GS4400@mwanda> diff --git a/a/1.txt b/N1/1.txt index 3e906bc..76edb81 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,11 +3,11 @@ On Wed, Jun 20, 2012 at 12:57:39PM +0530, santosh nayak wrote: > > There are 'NETXEN_NIU_MAX_GBE_PORTS' GBE ports. Port indexing starts > from zero. -> Hence we should also return error for "port = NETXEN_NIU_MAX_GBE_PORTS" +> Hence we should also return error for "port == NETXEN_NIU_MAX_GBE_PORTS" > I don't know this code well enough to say if you are right or not, -but what about for port = NETXEN_NIU_MAX_XG_PORTS a few lines later +but what about for port == NETXEN_NIU_MAX_XG_PORTS a few lines later in both functions? regards, diff --git a/a/content_digest b/N1/content_digest index f55988a..ecd872b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01340177259-14083-1-git-send-email-santoshprasadnayak@gmail.com\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH] netxen: Error return off by one in 'netxen_nic_set_pauseparam()'.\0" - "Date\0Wed, 20 Jun 2012 07:44:47 +0000\0" + "Date\0Wed, 20 Jun 2012 10:44:47 +0300\0" "To\0santosh nayak <santoshprasadnayak@gmail.com>\0" "Cc\0sony.chacko@qlogic.com" rajesh.borundia@qlogic.com @@ -14,14 +14,14 @@ "> \n" "> There are 'NETXEN_NIU_MAX_GBE_PORTS' GBE ports. Port indexing starts\n" "> from zero. \n" - "> Hence we should also return error for \"port = NETXEN_NIU_MAX_GBE_PORTS\"\n" + "> Hence we should also return error for \"port == NETXEN_NIU_MAX_GBE_PORTS\"\n" "> \n" "\n" "I don't know this code well enough to say if you are right or not,\n" - "but what about for port = NETXEN_NIU_MAX_XG_PORTS a few lines later\n" + "but what about for port == NETXEN_NIU_MAX_XG_PORTS a few lines later\n" "in both functions?\n" "\n" "regards,\n" dan carpenter -434382286aacdeab1c8daa9f3e31b508e8e44481eef228a549462a37956d6f9d +23d8a830008f6e7484b4f1f8af6cb1d0981aedf9de3c4dc7d468f7ccb298ebbe
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.