From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Yadwinder Singh Brar <yadi.brar01@gmail.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
Jonghwa Lee <jonghwa3.lee@samsung.com>,
Myungjoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chiwoong Byun <woong.byun@samsung.com>,
Axel Lin <axel.lin@gmail.com>,
Yadwinder Singh Brar <yadi.brar@samsung.com>
Subject: Re: [PATCH v2] regulator: max77686: Implement .set_ramp_delay() callback.
Date: Wed, 20 Jun 2012 11:18:24 +0100 [thread overview]
Message-ID: <20120620101824.GG3978@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1340169651-7844-1-git-send-email-yadi.brar@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
On Wed, Jun 20, 2012 at 10:50:51AM +0530, Yadwinder Singh Brar wrote:
> This patch implements the .set_ramp_delay callback to set the ramp_delay on
> hardware for BUCK2/3/4 if ramp_delay is set in regulator constraints.
Applied, thanks. It does seem reasonable to set the fastest ramp if the
ramp rate requested is over the maximum rate suported.
> This patch also do some cleaning work for unrequired members of
> struct max77686_data.
As Myungjoo said this really should have been split into a separate
patch, please don't do this in future. One patch per change.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-20 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 5:20 [PATCH v2] regulator: max77686: Implement .set_ramp_delay() callback Yadwinder Singh Brar
2012-06-20 7:08 ` Axel Lin
2012-06-20 10:18 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-06-20 6:56 MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620101824.GG3978@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=jonghwa3.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=myungjoo.ham@samsung.com \
--cc=woong.byun@samsung.com \
--cc=yadi.brar01@gmail.com \
--cc=yadi.brar@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.