On Wed, Jun 20, 2012 at 04:13:15PM +0800, Axel Lin wrote: > Return -EINVAL if pdata is NULL, otherwise we have NULL dereference bug. > This patch also moves the code checking pdata earlier in lp872x_probe. Applied, thanks. We should really not be insisting on pdata though.