From: Tony Lindgren <tony@atomide.com>
To: Joe Woodward <jw@terrafix.co.uk>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: board_onenand_init() build error in linux-next
Date: Wed, 20 Jun 2012 07:24:32 -0700 [thread overview]
Message-ID: <20120620142431.GP12766@atomide.com> (raw)
In-Reply-To: <WC20120615124650.94039B@terrafix.co.uk>
* Joe Woodward <jw@terrafix.co.uk> [120615 05:51]:
> Someone may have spotted this already...
>
> But if you build todays linux-next (next-20120615) without CONFIG_MTD_ONENAND_OMAP2 or
> CONFIG_MTD_ONENAND_OMAP2_MODULE then board_onenand_init() is defined in two places
> (in board-flash.c:102 as an empty function, and board-flash.h:56 as a static inline).
>
> This causes the build to fail as board-flash.c includes board-flash.h:
> CC arch/arm/mach-omap2/board-flash.o
> arch/arm/mach-omap2/board-flash.c:102:8: error: redefinition of 'board_onenand_init'
> arch/arm/mach-omap2/board-flash.h:56:20: note: previous definition of 'board_onenand_init'
> was here
> make[1]: *** [arch/arm/mach-omap2/board-flash.o] Error 1
>
> I'm fairly sure this isn't right!?
Yeah sounds like a bug, got a patch for it?
Tony
prev parent reply other threads:[~2012-06-20 14:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 12:46 board_onenand_init() build error in linux-next Joe Woodward
2012-06-20 14:24 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620142431.GP12766@atomide.com \
--to=tony@atomide.com \
--cc=jw@terrafix.co.uk \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.