All of lore.kernel.org
 help / color / mirror / Atom feed
From: aisheng.dong@freescale.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/1] ARM: imx: enable SPARSE_IRQ for imx
Date: Wed, 20 Jun 2012 22:45:04 +0800	[thread overview]
Message-ID: <20120620144503.GN10387@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <20120620125718.GA2253@S2101-09.ap.freescale.net>

On Wed, Jun 20, 2012 at 08:57:21PM +0800, Shawn Guo wrote:
> The conversation becomes really tedious.  I promise this is my last
> round reply to this.  In any case, what you proposed here is nothing
> imx specific.  If you want to go this way, please have it supported
> at driver core level.
> 
Anyway, i appreciate to your replies on my questions.
I will consider support in driver core level.

> On Wed, Jun 20, 2012 at 02:40:00PM +0800, Dong Aisheng wrote:
> > It's not about how struct resource defined.
> > It's about why you directly define linux irq for device rather than
> > using standard api irq_find_mapping to get the correct linux virt irq
> > for device after using irqdomain.
> > 
> It's all about that the irq in resource is defined as Linux irq.
> Whether you like it or not, that's a fact of Linux today.  I do not
> think I can repeat myself any more.
> 
I'm afraid you're missing my point.
I never said the irq in resource shouldn't be defined as linux irq.
My point is that irq number should be get via standard irqdomain api
rather than directly defining it yourself.

> > So you agree they're issues for non-dt?
> 
> No, not at all, because:
> 
> * non-DT should always use legacy domain.
> 
>   http://thread.gmane.org/gmane.linux.ports.arm.kernel/151860/focus=152072
> 
> * The SoC internal IRQs will always be allocated right after the
>   preallocated ones.
> 
> So the only thing that could impact those Linux irq numbering is the
> irqs preallocated by irq core.  I do not see why that preallocated
> number need to change from time to time.  The bottom line is that
We never konw what the future maybe, right?
And you may note even currently the irq core also provides an interface
to machine to define the preallocated irqs in machine_desc->nr_irqs.
That's changeable.

> all those Linux irqs are not open-coded but macros, which can be
> easily updated without any change to the users.
Using NR_IRQS_LEGACY as offset is not safe.

> > Hmm, how can you say NO one?
> > 
> Prove me wrong by proposing the change to driver core then, please.
> 
We can do it in core, but i still did not find enough reasons to do like that.
IMHO the device core may not want to know the mapping between hw irq and
linux virtual irq, that's all the work of iqr and irqdomain layer.
The device core may only want the user to tell him the linux irq(virtual),
that seems enough.
I would like to see if other people have different options.

Regards
Dong Aisheng

  reply	other threads:[~2012-06-20 14:45 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-14  5:59 [PATCH 00/16] Enable SPARSE_IRQ support for imx Shawn Guo
2012-06-14  5:59 ` Shawn Guo
2012-06-14  5:59 ` [PATCH 01/16] ARM: imx: eliminate macro IMX_GPIO_TO_IRQ() Shawn Guo
2012-06-14  7:31   ` Dong Aisheng
2012-06-14  7:39     ` Shawn Guo
2012-06-14  8:04       ` Dong Aisheng
2012-06-14  5:59 ` [PATCH 02/16] ARM: imx: eliminate macro IOMUX_TO_IRQ() Shawn Guo
2012-06-14  7:59   ` Dong Aisheng
2012-06-14  5:59 ` [PATCH 03/16] ARM: imx: eliminate macro IRQ_GPIOx() Shawn Guo
2012-06-15  9:23   ` Dong Aisheng
2012-06-14  5:59 ` [PATCH 04/16] gpio/mxc: move irq_domain_add_legacy call into gpio driver Shawn Guo
2012-06-15  9:26   ` Dong Aisheng
2012-06-14  5:59 ` [PATCH 05/16] ARM: imx: move irq_domain_add_legacy call into tzic driver Shawn Guo
2012-06-15  9:29   ` Dong Aisheng
2012-06-14  5:59 ` [PATCH 06/16] ARM: imx: move irq_domain_add_legacy call into avic driver Shawn Guo
2012-06-14  7:13   ` Shawn Guo
2012-06-15  9:30     ` Dong Aisheng
2012-07-06  6:26     ` [PATCH] ARM: imx: select IRQ_DOMAIN Uwe Kleine-König
2012-07-06  7:05       ` Shawn Guo
2012-07-06  7:07         ` Uwe Kleine-König
2012-07-06  7:12         ` Sascha Hauer
2012-07-06  7:18           ` [PATCH] ARM: imx: select USE_OF Uwe Kleine-König
2012-07-06  7:31             ` Shawn Guo
2012-07-06  7:47           ` [PATCH v2] " Uwe Kleine-König
2012-07-06  8:04             ` Shawn Guo
2012-07-06 19:15               ` Arnd Bergmann
2012-06-14  5:59 ` [PATCH 07/16] dma: ipu: remove the use of ipu_platform_data Shawn Guo
2012-06-14 10:26   ` Vinod Koul
2012-06-15  9:37   ` Dong Aisheng
2012-06-16  3:01     ` Shawn Guo
2012-06-18  8:19       ` Dong Aisheng
2012-06-18 14:02         ` Shawn Guo
2012-06-19  5:51           ` Dong Aisheng
2012-06-14  5:59 ` [PATCH 08/16] ARM: imx: leave irq_base of wm8350_platform_data uninitialized Shawn Guo
2012-06-15 12:20   ` Dong Aisheng
2012-06-14  5:59 ` [PATCH 09/16] ARM: imx: pass gpio than irq number into mxc_expio_init Shawn Guo
2012-06-15 12:21   ` Dong Aisheng
2012-06-14  5:59 ` [PATCH 10/16] ARM: imx: add a legacy irqdomain for 3ds_debugboard Shawn Guo
2012-06-15 12:22   ` Dong Aisheng
2012-06-14  5:59 ` [PATCH 11/16] ARM: imx: add a legacy irqdomain for mx31ads Shawn Guo
2012-06-18  8:20   ` Dong Aisheng
     [not found] ` <1339653587-4832-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-06-14  5:59   ` [PATCH 12/16] i2c: imx: remove unneeded mach/irqs.h inclusion Shawn Guo
2012-06-14  5:59     ` Shawn Guo
     [not found]     ` <1339653587-4832-13-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-06-14  7:30       ` Wolfram Sang
2012-06-14  7:30         ` Wolfram Sang
2012-06-18  8:20       ` Dong Aisheng
2012-06-18  8:20         ` Dong Aisheng
2012-06-14  5:59 ` [PATCH 13/16] ARM: imx: remove unneeded mach/irq.h inclusion Shawn Guo
2012-06-18  8:21   ` Dong Aisheng
2012-06-14  5:59 ` [PATCH 14/16] tty: serial: imx: remove the use of MXC_INTERNAL_IRQS Shawn Guo
2012-06-14  5:59   ` Shawn Guo
2012-06-14 15:37   ` Greg Kroah-Hartman
2012-06-14 15:37     ` Greg Kroah-Hartman
2012-06-18  8:22   ` Dong Aisheng
2012-06-18  8:22     ` Dong Aisheng
2012-06-14  5:59 ` [PATCH 15/16] ARM: fiq: save FIQ_START by passing absolute fiq number Shawn Guo
2012-06-18  8:39   ` Dong Aisheng
2012-06-18 14:31   ` Shawn Guo
2012-06-18 16:44     ` Russell King - ARM Linux
2012-06-19  5:26       ` Shawn Guo
2012-06-20 22:55         ` Russell King - ARM Linux
2012-06-20 23:40           ` Shawn Guo
2012-06-20 23:53           ` Shawn Guo
2012-06-21  7:37             ` Russell King - ARM Linux
2012-06-21  8:50           ` Shawn Guo
2012-06-25 16:10           ` Shawn Guo
2012-06-14  5:59 ` [PATCH 16/16] ARM: imx: enable SPARSE_IRQ for imx platform Shawn Guo
2012-06-14  7:40   ` Haojian Zhuang
2012-06-14  7:55     ` Shawn Guo
2012-06-18  8:48   ` Dong Aisheng
2012-06-18 15:04     ` Shawn Guo
2012-06-19  6:16       ` Dong Aisheng
2012-06-19  6:47         ` Shawn Guo
2012-06-19  7:21           ` Dong Aisheng
2012-06-19  7:43             ` Shawn Guo
2012-06-19 13:01               ` Dong Aisheng
2012-06-19 13:19                 ` [RFC PATCH 1/1] ARM: imx: enable SPARSE_IRQ for imx Dong Aisheng
2012-06-19 14:06                   ` Shawn Guo
2012-06-20  2:23                     ` Dong Aisheng
2012-06-20  5:40                       ` Shawn Guo
2012-06-20  6:40                         ` Dong Aisheng
2012-06-20 12:57                           ` Shawn Guo
2012-06-20 14:45                             ` Dong Aisheng [this message]
2012-06-14  8:00 ` [PATCH 00/16] Enable SPARSE_IRQ support " Sascha Hauer
2012-06-14  8:00   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120620144503.GN10387@shlinux2.ap.freescale.net \
    --to=aisheng.dong@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.