All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	devel@driverdev.osuosl.org, fmhess@users.sourceforge.net,
	abbotti@mev.co.uk
Subject: Re: [PATCH] staging: comedi: skel: use module_comedi_{pci_,}driver()
Date: Wed, 20 Jun 2012 16:12:30 -0700	[thread overview]
Message-ID: <20120620231230.GA28411@kroah.com> (raw)
In-Reply-To: <201206201556.51336.hartleys@visionengravers.com>

On Wed, Jun 20, 2012 at 03:56:50PM -0700, H Hartley Sweeten wrote:
> If PCI boards are supported, use the module_comedi_pci_driver() macro
> to register the module as a comedi driver and a PCI driver. Otherwise,
> only ISA boards are supported to use the module_comedi_driver() macro
> to register the module as a comedi driver.
> 
> Refactor the code a bit due to the use of the module_comedi_* macros.
> 
> Rename the comedi_driver and pci_driver variables as well as the pci
> driver related functions for aesthetic reasons. This makes the skel
> driver conform to the changes to the other comedi drivers.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ian Abbott <abbotti@mev.co.uk>
> Cc: Frank Mori Hess <fmhess@users.sourceforge.net>

This patch fails to apply:

patching file drivers/staging/comedi/drivers/skel.c
Hunk #4 FAILED at 543.
1 out of 4 hunks FAILED -- saving rejects to file drivers/staging/comedi/drivers/skel.c.rej

Care to rediff it and resend?

thanks,

greg k-h

  reply	other threads:[~2012-06-20 23:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-20 22:56 [PATCH] staging: comedi: skel: use module_comedi_{pci_,}driver() H Hartley Sweeten
2012-06-20 23:12 ` Greg KH [this message]
2012-06-20 23:16   ` H Hartley Sweeten
2012-06-20 23:23     ` Greg KH
2012-06-21  0:21       ` H Hartley Sweeten
2012-06-21  0:28         ` Greg KH
2012-06-21  9:01         ` Ian Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120620231230.GA28411@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=fmhess@users.sourceforge.net \
    --cc=hartleys@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.