From: Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Gerd Hoffmann <kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/7] Revert "usb/uas: one only one status URB/host on stream-less connection"
Date: Wed, 20 Jun 2012 16:56:44 -0700 [thread overview]
Message-ID: <20120620235644.GD31520@kroah.com> (raw)
In-Reply-To: <1340092494-18876-3-git-send-email-kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Tue, Jun 19, 2012 at 09:54:49AM +0200, Gerd Hoffmann wrote:
> This reverts commit ceb3f91fd53c9fbd7b292fc2754ba4efffeeeedb.
>
> IMO the real bug is assigning status urbs to scsi requests. First there
> is no such link in the non-stream case. Also there isn't nessesarely a
> scsi request in the first place, for example when submitting task
> management requests.
>
> This patch just papers over the real bug and introduces different status
> urb handling in the stream/non-stream case for no good reason.
>
> Signed-off-by: Gerd Hoffmann <kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/usb/storage/uas.c | 70 ++++++--------------------------------------
> 1 files changed, 10 insertions(+), 60 deletions(-)
Same here, should this also be reverted in 3.4-stable?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-06-20 23:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 7:54 [PATCH 0/7] uas: various fixes, add error handling Gerd Hoffmann
[not found] ` <1340092494-18876-1-git-send-email-kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-06-19 7:54 ` [PATCH 1/7] Revert "usb/uas: make sure data urb is gone if we receive status before that" Gerd Hoffmann
2012-06-20 23:56 ` Greg KH
[not found] ` <20120620235626.GC31520-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2012-06-21 8:27 ` Gerd Hoffmann
2012-06-19 7:54 ` [PATCH 2/7] Revert "usb/uas: one only one status URB/host on stream-less connection" Gerd Hoffmann
[not found] ` <1340092494-18876-3-git-send-email-kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-06-20 23:56 ` Greg KH [this message]
2012-06-21 8:41 ` Gerd Hoffmann
2012-06-25 18:49 ` Greg KH
2012-06-19 7:54 ` [PATCH 3/7] uas: fix sense urb handling Gerd Hoffmann
2012-06-19 7:54 ` [PATCH 7/7] uas: task mgmt & error handling Gerd Hoffmann
2012-06-19 7:54 ` [PATCH 4/7] uas: keep track of command state, finish scsi cmd when really done Gerd Hoffmann
2012-06-19 7:54 ` [PATCH 5/7] uas: improve error handling Gerd Hoffmann
2012-06-19 7:54 ` [PATCH 6/7] uas: track urbs, kill inflight urbs on disconnect Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620235644.GD31520@kroah.com \
--to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
--cc=kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.