From: aisheng.dong@freescale.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] pinctrl: pinctrl-imx: fix map setting problem if NO_PAD_CTL is set
Date: Thu, 21 Jun 2012 10:13:59 +0800 [thread overview]
Message-ID: <20120621021358.GO10387@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <CACRpkdYXuRC0d1NcUEfRZbfgis+9xVyzsEFpGmS21xYBmyrAPg@mail.gmail.com>
On Wed, Jun 20, 2012 at 09:25:35PM +0200, Linus Walleij wrote:
> On Wed, Jun 20, 2012 at 12:13 PM, Hui Wang <jason77.wang@gmail.com> wrote:
>
> > new_map is allocated according to map_num instead of grp->npins,
> > if a pin or some pins of a group has NO_PAD_CTL property, the map_num
> > and the grp->npin are different definitely.
> >
> > When we set mapping information to the new_map[], we should skip those
> > pins with NO_PAD_CTL from index, otherwise it is possible the driver
> > will aceesss to a unallocated region.
> >
> > Cc: Dong Aisheng <dong.aisheng@linaro.org>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: Shawn Guo <shawn.guo@linaro.org>
> > Signed-off-by: Hui Wang <jason77.wang@gmail.com>
> > ---
> > In the v2, according to dong.aisheng's suggestion, change to use j as index.
>
> OK applied this v2 version. Is this a serious bug fix that is causing
> regressions right now and needs to go into the -rc:s for v3.5 or can it wait
> for v3.6?
>
Yes, it's a serious bug fix.
Although still not triggered by current dts file but it did may block some legal using
defined in binding doc.
So can it go into rc?
Regards
Dong Aisheng
prev parent reply other threads:[~2012-06-21 2:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 10:13 [PATCH v2] pinctrl: pinctrl-imx: fix map setting problem if NO_PAD_CTL is set Hui Wang
2012-06-20 10:28 ` Dong Aisheng
2012-06-20 19:25 ` Linus Walleij
2012-06-21 1:08 ` Hui Wang
2012-06-21 2:13 ` Dong Aisheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621021358.GO10387@shlinux2.ap.freescale.net \
--to=aisheng.dong@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.