From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: "Girdwood, Liam" <lrg@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"axel.lin@gmail.com" <axel.lin@gmail.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>
Subject: Re: [PATCH 2/3] regulator: replace devm_gpio_request_one() for loaded module
Date: Thu, 21 Jun 2012 10:20:27 +0100 [thread overview]
Message-ID: <20120621092026.GJ4037@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998FC052@DQHE02.ent.ti.com>
[-- Attachment #1: Type: text/plain, Size: 529 bytes --]
On Thu, Jun 21, 2012 at 08:03:48AM +0000, Kim, Milo wrote:
> At this moment, devm_gpio_request_one() has not been exported yet.
> But lp872x driver can be used as a module, so related functions should be changed.
>
> devm_gpio_request_one() -> gpio_request_one() and gpio_free()
No, this is a step back in terms of the quality of the driver especially
given that nobody is likely to actually use the driver when built as a
module. We should just wait until the function is exported and then
reenable modular builds.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-06-21 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 8:03 [PATCH 2/3] regulator: replace devm_gpio_request_one() for loaded module Kim, Milo
2012-06-21 9:20 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621092026.GJ4037@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Milo.Kim@ti.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sfr@canb.auug.org.au \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.