From: Ralf Baechle <ralf@linux-mips.org>
To: Florian Fainelli <florian@openwrt.org>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
Kelvin Cheung <keguang.zhang@gmail.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
wuzhangjin@gmail.com, zhzhl555@gmail.com
Subject: Re: [PATCH V7 2/4] MIPS: Add board support for Loongson1B
Date: Thu, 21 Jun 2012 12:32:34 +0100 [thread overview]
Message-ID: <20120621113234.GB7175@linux-mips.org> (raw)
In-Reply-To: <1463808.aB2kcWCEuH@bender>
On Wed, Jun 20, 2012 at 10:10:26PM +0200, Florian Fainelli wrote:
> > > This redefines a function that already is declared in <linux/clk.h> and
> > > defined in drivers/clk/clkdev.c. Why?
> >
> > Because he doesn't support clkdev? clkdev support is optional.
>
> I don't think it is a good idea not to support clkdev for new targets. Ralf
> what do you think about it?
My gut feeling is that if there's a suitable generic infrastructure we
should use it, so use clkdev for new targets. I was just wondering if
there's a good reason to doing things the way he did.
Ralf
next prev parent reply other threads:[~2012-06-21 11:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 10:53 [PATCH V7 0/4] MIPS: Add support for Loongson1B Kelvin Cheung
2012-06-15 10:53 ` [PATCH V7 1/4] MIPS: Add CPU " Kelvin Cheung
2012-06-20 19:13 ` Ralf Baechle
2012-06-15 10:53 ` [PATCH V7 2/4] MIPS: Add board " Kelvin Cheung
2012-06-20 19:25 ` Ralf Baechle
2012-06-20 19:35 ` Sergei Shtylyov
2012-06-20 20:10 ` Florian Fainelli
2012-06-21 11:32 ` Ralf Baechle [this message]
2012-06-21 7:37 ` Kelvin Cheung
2012-06-21 7:34 ` Kelvin Cheung
2012-06-21 8:18 ` Florian Fainelli
2012-06-21 9:11 ` Kelvin Cheung
2012-06-21 9:52 ` Florian Fainelli
2012-06-15 10:53 ` [PATCH V7 3/4] MIPS: Add Makefile and Kconfig " Kelvin Cheung
2012-06-15 10:53 ` [PATCH V7 4/4] MIPS: Add defconfig " Kelvin Cheung
-- strict thread matches above, loose matches on Subject: below --
2012-07-07 9:29 [PATCH V7 2/4] MIPS: Add board support " Kelvin Cheung
2012-07-24 15:24 ` Kelvin Cheung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621113234.GB7175@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=florian@openwrt.org \
--cc=keguang.zhang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=sshtylyov@mvista.com \
--cc=wuzhangjin@gmail.com \
--cc=zhzhl555@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.