From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kalle Valo <kvalo@adurom.com>
Cc: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] ath9k_hw: fix smatch warnings in spur_mitigate
Date: Fri, 22 Jun 2012 14:57:47 +0300 [thread overview]
Message-ID: <20120622115747.GE5390@mwanda> (raw)
In-Reply-To: <877guz4lm9.fsf@purkki.adurom.net>
On Fri, Jun 22, 2012 at 02:44:14PM +0300, Kalle Valo wrote:
> Rajkumar Manoharan <rmanohar@qca.qualcomm.com> writes:
>
> >> > - qCoff = qCoff & 0x7f;
> >> > + qCoff &= 0x7f;
> >>
> >> I'm curious, how does a change like this fix anything? To me it just
> >> looks same functionality, just a different operator is used. Am I
> >> missing something?
> >
> > Though it doesn't make a difference, somehow it fixes smatch warning.
> > I agree it is not the right fix.
>
> Ok, maybe it's just that smatch isn't clever enough with the &= operator.
> Dan?
Ugh... I think it's debugging code that leaked into the wild. I
will remove that.
regards,
dan carpenter
next prev parent reply other threads:[~2012-06-22 11:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 18:31 [PATCH 0/3] ath9k: Fix smatch warnings Rajkumar Manoharan
2012-06-21 18:31 ` [PATCH 1/3] ath9k_hw: fix buffer overflow smatch warning Rajkumar Manoharan
2012-06-21 18:31 ` [PATCH 2/3] ath9k_hw: fix smatch warnings in spur_mitigate Rajkumar Manoharan
2012-06-22 7:23 ` Kalle Valo
2012-06-22 9:22 ` Rajkumar Manoharan
2012-06-22 11:44 ` Kalle Valo
2012-06-22 11:57 ` Dan Carpenter [this message]
2012-06-22 12:42 ` Rajkumar Manoharan
2012-06-21 18:31 ` [PATCH 3/3] ath9k: fix 'side effect in macro' smatch warning Rajkumar Manoharan
2012-06-21 18:42 ` Ben Greear
2012-06-21 19:07 ` Rajkumar Manoharan
2012-06-21 19:15 ` Ben Greear
2012-06-21 19:20 ` Rajkumar Manoharan
2012-06-22 7:17 ` Kalle Valo
2012-06-22 11:55 ` Dan Carpenter
2012-06-22 14:24 ` Ben Greear
2012-06-22 14:32 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120622115747.GE5390@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanohar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.