From: Fengguang Wu <fengguang.wu@intel.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: BUG: tracer_alloc_buffers returned with preemption imbalance
Date: Sun, 24 Jun 2012 01:48:30 +0800 [thread overview]
Message-ID: <20120623174830.GA5617@localhost> (raw)
In-Reply-To: <20120623170147.GI2516@linux.vnet.ibm.com>
> > static inline int rcu_blocking_is_gp(void)
> > {
> > might_sleep(); /* Check for RCU read-side critical section. */
> > + preempt_disable();
> > return num_online_cpus() <= 1;
> > + preempt_enable();
> > }
>
> Thank you! I have no idea how a preempt_disable() causes that badness
> to happen, but this commit is not yet critically important, so I will
> drop it.
preempt_enable() becomes dead code because of the return statement?
I wonder why gcc didn't issue a warning (or I failed to catch it)...
Thanks,
Fengguang
next prev parent reply other threads:[~2012-06-23 17:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-23 10:12 BUG: tracer_alloc_buffers returned with preemption imbalance Fengguang Wu
2012-06-23 17:01 ` Paul E. McKenney
2012-06-23 17:48 ` Fengguang Wu [this message]
2012-06-23 20:11 ` Paul E. McKenney
2012-06-24 8:37 ` Cong Wang
2012-06-25 3:57 ` Paul E. McKenney
2012-06-25 9:10 ` David Rientjes
2012-06-25 13:20 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120623174830.GA5617@localhost \
--to=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.