From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] imx: Use a clear identification of an unidentified CPU type
Date: Sun, 24 Jun 2012 08:57:06 +0200 [thread overview]
Message-ID: <20120624065706.ABD192000ED@gemini.denx.de> (raw)
In-Reply-To: <1340482108-18468-4-git-send-email-otavio@ossystems.com.br>
Dear Otavio Salvador,
In message <1340482108-18468-4-git-send-email-otavio@ossystems.com.br> you wrote:
> In case an unidentified CPU type is detected it now returns
> i.MX<unidentified>, in a const char.
...
> -static char *get_imx_type(u32 imxtype)
> +static const char *get_imx_type(u32 imxtype)
I agree with the const change.
> - return "unknown";
> + return "<unidentified>";
But in which way would "<unidentified>" be better than "unknown"? It
just costs 7 more bytes of memory...
Please drop this change.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Success covers a multitude of blunders." - George Bernard Shaw
next prev parent reply other threads:[~2012-06-24 6:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-23 20:08 [U-Boot] [PATCH 1/4] cmd_bootm: fix compilation warning for assigned but never used variable Otavio Salvador
2012-06-23 20:08 ` [U-Boot] [PATCH 2/4] mx53loco: add a comment about local copy of print_cpuinfo method Otavio Salvador
2012-06-23 20:07 ` Otavio Salvador
2012-06-23 20:09 ` Marek Vasut
2012-06-24 7:53 ` Wolfgang Denk
2012-06-24 19:02 ` Otavio Salvador
2012-06-24 22:04 ` Wolfgang Denk
2012-06-24 22:10 ` Otavio Salvador
2012-06-23 20:08 ` [U-Boot] [PATCH 2/4] mx53loco: Add a comment about local print_cpuinfo method in board file Otavio Salvador
2012-06-24 7:55 ` Wolfgang Denk
2012-06-24 19:11 ` Otavio Salvador
2012-06-24 21:23 ` Otavio Salvador
2012-06-24 22:05 ` Wolfgang Denk
2012-06-24 22:12 ` Otavio Salvador
2012-06-24 22:53 ` Wolfgang Denk
2012-06-25 3:35 ` Fabio Estevam
2012-06-23 20:08 ` [U-Boot] [PATCH 3/4] imx: Use a clear identification of an unidentified CPU type Otavio Salvador
2012-06-24 6:57 ` Wolfgang Denk [this message]
2012-06-24 13:08 ` Marek Vasut
2012-06-24 13:19 ` Fabio Estevam
2012-06-24 13:43 ` Marek Vasut
2012-06-24 13:52 ` Wolfgang Denk
2012-06-24 19:48 ` Otavio Salvador
2012-06-24 19:53 ` Marek Vasut
2012-06-24 19:57 ` Otavio Salvador
2012-06-24 22:08 ` Wolfgang Denk
2012-06-24 22:17 ` Otavio Salvador
2012-06-25 0:20 ` Marek Vasut
2012-06-23 20:08 ` [U-Boot] [PATCH 4/4] mxs: generalize code for print_cpuinfo() Otavio Salvador
2012-06-23 20:08 ` Marek Vasut
2012-06-23 20:31 ` [U-Boot] [PATCH 4/4 v2] " Otavio Salvador
2012-06-23 22:56 ` [U-Boot] [PATCH 1/4] cmd_bootm: fix compilation warning for assigned but never used variable Wolfgang Denk
2012-06-23 23:00 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120624065706.ABD192000ED@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.