From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wanpeng Li Subject: Re: [PATCH v3 3/4] memcg: optimize memcg_get_hierarchical_limit Date: Mon, 25 Jun 2012 18:43:57 +0800 Message-ID: <20120625104357.GB12148@kernel> References: <1340613872-9581-1-git-send-email-liwp.linux@gmail.com> <4FE834D9.8070903@jp.fujitsu.com> Reply-To: Wanpeng Li Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=NiAHCZSvcJ5wAgNOVGBeRptphGpJ2j/QMYJKvL189CE=; b=wFhCqV3rF1APio/TJkYMFzv8pa2vlaOaEUd0hcUlM75k6E/ntOCRie97Tdw9vQdmBS W+i4FiK4cP2GWRsKdlL6pC5w+M/8jjtXMNEDXKnKHm7xxg754IwRkqrl9PobpvlvgJMt VVL41AQN1Ug6Rxr5dFAJlktAZvtBvxM69aIPUqmej207onWTgBts9OKYyQjiW+p9kJxJ Izic3ZpW4ppA5ByvKa7AKe6+mrzz1Qe9254qALlndljEqWaoj1G91B78zRvcOFnxN7OD IkPV9i+CZe6kJ6u6Q1kBjGymJ/rLPDMA4TNX9ITnldHYQEOAjSw38WFQboXXZy7CO5jX TzIg== Content-Disposition: inline In-Reply-To: <4FE834D9.8070903-+CUm20s59erQFUHtdCDX3A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kamezawa Hiroyuki Cc: Michal Hocko , Johannes Weiner , Balbir Singh , Andrew Morton , Eric Dumazet , Mike Frysinger , Arun Sharma , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wanpeng Li On Mon, Jun 25, 2012 at 06:52:25PM +0900, Kamezawa Hiroyuki wrote: >(2012/06/25 17:44), Wanpeng Li wrote: >> From: Wanpeng Li >> >> Optimize memcg_get_hierarchical_limit to save cpu cycle. >> >> Signed-off-by: Wanpeng Li > >I can't understand the benefit of this patch to the real world... > >So, if you wrote the patch description as "clean up" rather than optimize, >ok, I'll agree. OK, I will change to "Cleanup". Thank you Kame. Best Regards, Wanpeng Li > >Thanks, >-Kame > >> --- >> mm/memcontrol.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >> index 2e81328..4520b57 100644 >> --- a/mm/memcontrol.c >> +++ b/mm/memcontrol.c >> @@ -3917,9 +3917,9 @@ static void memcg_get_hierarchical_limit(struct mem_cgroup *memcg, >> >> min_limit = res_counter_read_u64(&memcg->res, RES_LIMIT); >> min_memsw_limit = res_counter_read_u64(&memcg->memsw, RES_LIMIT); >> - cgroup = memcg->css.cgroup; >> if (!memcg->use_hierarchy) >> goto out; >> + cgroup = memcg->css.cgroup; >> >> while (cgroup->parent) { >> cgroup = cgroup->parent; >> > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755861Ab2FYKon (ORCPT ); Mon, 25 Jun 2012 06:44:43 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:42447 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755729Ab2FYKol (ORCPT ); Mon, 25 Jun 2012 06:44:41 -0400 Date: Mon, 25 Jun 2012 18:43:57 +0800 From: Wanpeng Li To: Kamezawa Hiroyuki Cc: Michal Hocko , Johannes Weiner , Balbir Singh , Andrew Morton , Eric Dumazet , Mike Frysinger , Arun Sharma , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Wanpeng Li Subject: Re: [PATCH v3 3/4] memcg: optimize memcg_get_hierarchical_limit Message-ID: <20120625104357.GB12148@kernel> Reply-To: Wanpeng Li References: <1340613872-9581-1-git-send-email-liwp.linux@gmail.com> <4FE834D9.8070903@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FE834D9.8070903@jp.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 25, 2012 at 06:52:25PM +0900, Kamezawa Hiroyuki wrote: >(2012/06/25 17:44), Wanpeng Li wrote: >> From: Wanpeng Li >> >> Optimize memcg_get_hierarchical_limit to save cpu cycle. >> >> Signed-off-by: Wanpeng Li > >I can't understand the benefit of this patch to the real world... > >So, if you wrote the patch description as "clean up" rather than optimize, >ok, I'll agree. OK, I will change to "Cleanup". Thank you Kame. Best Regards, Wanpeng Li > >Thanks, >-Kame > >> --- >> mm/memcontrol.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >> index 2e81328..4520b57 100644 >> --- a/mm/memcontrol.c >> +++ b/mm/memcontrol.c >> @@ -3917,9 +3917,9 @@ static void memcg_get_hierarchical_limit(struct mem_cgroup *memcg, >> >> min_limit = res_counter_read_u64(&memcg->res, RES_LIMIT); >> min_memsw_limit = res_counter_read_u64(&memcg->memsw, RES_LIMIT); >> - cgroup = memcg->css.cgroup; >> if (!memcg->use_hierarchy) >> goto out; >> + cgroup = memcg->css.cgroup; >> >> while (cgroup->parent) { >> cgroup = cgroup->parent; >> > > >