From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wanpeng Li Subject: Re: [PATCH v3 3/4] memcg: optimize memcg_get_hierarchical_limit Date: Mon, 25 Jun 2012 19:19:29 +0800 Message-ID: <20120625111929.GC12148@kernel> References: <1340613872-9581-1-git-send-email-liwp.linux@gmail.com> <4FE834D9.8070903@jp.fujitsu.com> <20120625104357.GB12148@kernel> <20120625110926.GJ19805@tiehlicka.suse.cz> Reply-To: Wanpeng Li Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=LRttCSiO7Hm/+/NL50B9tAOj/lNlqbfoM00X9WruJcc=; b=jzsicagEDDIlYM2rrReu+Qr46VQipy+BfzvN3u8lCmRZXtbJuk2cz8/8Kmv6dntHcR RIQ6mfEC0zP6Skye86iK4qPuWLZb4oVCm9GDmXrDdkN09/MABF0Q7olUwK+H/FL2i0gR tqlha1o29UMx6mMrOmQ/zEJwXTQBzLlwHmv4daR0ioRjZY+ZtzH8NZTuLb1ONlXinGS4 /xw6FwpWB6rwFspXlqWWCh6j+8NeUUYTujsMBFht2iqZT1OqZrB/65pap6vFKnZUoJTO LBrP3C6ahIl2q3TyuGIUjLBGE/gAnt/bRTTu7/LFqTBDIFJiXp/XOT3zUtyXhNQ8lEtA /Rfw== Content-Disposition: inline In-Reply-To: <20120625110926.GJ19805-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh , Andrew Morton , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wanpeng Li On Mon, Jun 25, 2012 at 01:09:26PM +0200, Michal Hocko wrote: >On Mon 25-06-12 18:43:57, Wanpeng Li wrote: >> On Mon, Jun 25, 2012 at 06:52:25PM +0900, Kamezawa Hiroyuki wrote: >> >(2012/06/25 17:44), Wanpeng Li wrote: >> >> From: Wanpeng Li >> >> >> >> Optimize memcg_get_hierarchical_limit to save cpu cycle. >> >> >> >> Signed-off-by: Wanpeng Li >> > >> >I can't understand the benefit of this patch to the real world... >> > >> >So, if you wrote the patch description as "clean up" rather than optimize, >> >ok, I'll agree. >> OK, I will change to "Cleanup". Thank you Kame. > >Does this really clean something up? OK, just drop it and resend the patch. Hopefully, you can applied! :-) Best Regards, Wanpeng Li >-- >Michal Hocko >SUSE Labs >SUSE LINUX s.r.o. >Lihovarska 1060/12 >190 00 Praha 9 >Czech Republic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756033Ab2FYLTl (ORCPT ); Mon, 25 Jun 2012 07:19:41 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:60274 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755832Ab2FYLTj (ORCPT ); Mon, 25 Jun 2012 07:19:39 -0400 Date: Mon, 25 Jun 2012 19:19:29 +0800 From: Wanpeng Li To: Michal Hocko Cc: Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh , Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Wanpeng Li Subject: Re: [PATCH v3 3/4] memcg: optimize memcg_get_hierarchical_limit Message-ID: <20120625111929.GC12148@kernel> Reply-To: Wanpeng Li References: <1340613872-9581-1-git-send-email-liwp.linux@gmail.com> <4FE834D9.8070903@jp.fujitsu.com> <20120625104357.GB12148@kernel> <20120625110926.GJ19805@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120625110926.GJ19805@tiehlicka.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 25, 2012 at 01:09:26PM +0200, Michal Hocko wrote: >On Mon 25-06-12 18:43:57, Wanpeng Li wrote: >> On Mon, Jun 25, 2012 at 06:52:25PM +0900, Kamezawa Hiroyuki wrote: >> >(2012/06/25 17:44), Wanpeng Li wrote: >> >> From: Wanpeng Li >> >> >> >> Optimize memcg_get_hierarchical_limit to save cpu cycle. >> >> >> >> Signed-off-by: Wanpeng Li >> > >> >I can't understand the benefit of this patch to the real world... >> > >> >So, if you wrote the patch description as "clean up" rather than optimize, >> >ok, I'll agree. >> OK, I will change to "Cleanup". Thank you Kame. > >Does this really clean something up? OK, just drop it and resend the patch. Hopefully, you can applied! :-) Best Regards, Wanpeng Li >-- >Michal Hocko >SUSE Labs >SUSE LINUX s.r.o. >Lihovarska 1060/12 >190 00 Praha 9 >Czech Republic