* [PATCH] Staging: vt6656: int.c: A few trivial style cleanups
@ 2012-06-24 20:12 Jesper Juhl
2012-06-25 17:47 ` Greg Kroah-Hartman
0 siblings, 1 reply; 10+ messages in thread
From: Jesper Juhl @ 2012-06-24 20:12 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Forest Bond, Jiri Kosina, Marcos Paulo de Souza, devel,
linux-kernel, trivial
Removed a pointless cast + some whitespace cleanups.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
drivers/staging/vt6656/int.c | 52 ++++++++++++++++++++------------------------
drivers/staging/vt6656/int.h | 43 ++++++++++++++++++------------------
2 files changed, 45 insertions(+), 50 deletions(-)
Note: I don't have hardware to test. Compile tested only.
diff --git a/drivers/staging/vt6656/int.c b/drivers/staging/vt6656/int.c
index 0a11423..35214b4 100644
--- a/drivers/staging/vt6656/int.c
+++ b/drivers/staging/vt6656/int.c
@@ -41,9 +41,7 @@
#include "usbpipe.h"
/*--------------------- Static Definitions -------------------------*/
-/* static int msglevel = MSG_LEVEL_DEBUG; */
-static int msglevel = MSG_LEVEL_INFO;
-
+static int msglevel = MSG_LEVEL_INFO; /* MSG_LEVEL_DEBUG */
/*--------------------- Static Classes ----------------------------*/
@@ -53,10 +51,8 @@ static int msglevel = MSG_LEVEL_INFO;
/*--------------------- Export Variables --------------------------*/
-
/*--------------------- Export Functions --------------------------*/
-
/*+
*
* Function: InterruptPollingThread
@@ -81,7 +77,7 @@ static int msglevel = MSG_LEVEL_INFO;
-*/
void INTvWorkItem(void *Context)
{
- PSDevice pDevice = (PSDevice) Context;
+ PSDevice pDevice = Context;
int ntStatus;
DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"---->Interrupt Polling Thread\n");
@@ -94,17 +90,17 @@ void INTvWorkItem(void *Context)
void INTnsProcessData(PSDevice pDevice)
{
- PSINTData pINTData;
- PSMgmtObject pMgmt = &(pDevice->sMgmtObj);
+ PSINTData pINTData;
+ PSMgmtObject pMgmt = &(pDevice->sMgmtObj);
struct net_device_stats *pStats = &pDevice->stats;
DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"---->s_nsInterruptProcessData\n");
- pINTData = (PSINTData) pDevice->intBuf.pDataBuf;
+ pINTData = (PSINTData)pDevice->intBuf.pDataBuf;
if (pINTData->byTSR0 & TSR_VALID) {
STAvUpdateTDStatCounter(&(pDevice->scStatistic),
- (BYTE) (pINTData->byPkt0 & 0x0F),
- (BYTE) (pINTData->byPkt0>>4),
+ (BYTE)(pINTData->byPkt0 & 0x0F),
+ (BYTE)(pINTData->byPkt0 >> 4),
pINTData->byTSR0);
BSSvUpdateNodeTxCounter(pDevice,
&(pDevice->scStatistic),
@@ -114,8 +110,8 @@ void INTnsProcessData(PSDevice pDevice)
}
if (pINTData->byTSR1 & TSR_VALID) {
STAvUpdateTDStatCounter(&(pDevice->scStatistic),
- (BYTE) (pINTData->byPkt1 & 0x0F),
- (BYTE) (pINTData->byPkt1>>4),
+ (BYTE)(pINTData->byPkt1 & 0x0F),
+ (BYTE)(pINTData->byPkt1 >> 4),
pINTData->byTSR1);
BSSvUpdateNodeTxCounter(pDevice,
&(pDevice->scStatistic),
@@ -125,8 +121,8 @@ void INTnsProcessData(PSDevice pDevice)
}
if (pINTData->byTSR2 & TSR_VALID) {
STAvUpdateTDStatCounter(&(pDevice->scStatistic),
- (BYTE) (pINTData->byPkt2 & 0x0F),
- (BYTE) (pINTData->byPkt2>>4),
+ (BYTE)(pINTData->byPkt2 & 0x0F),
+ (BYTE)(pINTData->byPkt2 >> 4),
pINTData->byTSR2);
BSSvUpdateNodeTxCounter(pDevice,
&(pDevice->scStatistic),
@@ -136,8 +132,8 @@ void INTnsProcessData(PSDevice pDevice)
}
if (pINTData->byTSR3 & TSR_VALID) {
STAvUpdateTDStatCounter(&(pDevice->scStatistic),
- (BYTE) (pINTData->byPkt3 & 0x0F),
- (BYTE) (pINTData->byPkt3>>4),
+ (BYTE)(pINTData->byPkt3 & 0x0F),
+ (BYTE)(pINTData->byPkt3 >> 4),
pINTData->byTSR3);
BSSvUpdateNodeTxCounter(pDevice,
&(pDevice->scStatistic),
@@ -158,34 +154,34 @@ void INTnsProcessData(PSDevice pDevice)
pMgmt->byDTIMPeriod-1;
pMgmt->sNodeDBTable[0].bRxPSPoll = TRUE;
if (pMgmt->sNodeDBTable[0].bPSEnable)
- bScheduleCommand((void *) pDevice,
- WLAN_CMD_RX_PSPOLL,
- NULL);
+ bScheduleCommand((void *)pDevice,
+ WLAN_CMD_RX_PSPOLL,
+ NULL);
}
- bScheduleCommand((void *) pDevice,
+ bScheduleCommand((void *)pDevice,
WLAN_CMD_BECON_SEND,
NULL);
} /* if (pDevice->eOPMode == OP_MODE_AP) */
- pDevice->bBeaconSent = TRUE;
+ pDevice->bBeaconSent = TRUE;
} else {
pDevice->bBeaconSent = FALSE;
}
if (pINTData->byISR0 & ISR_TBTT) {
if (pDevice->bEnablePSMode)
- bScheduleCommand((void *) pDevice,
+ bScheduleCommand((void *)pDevice,
WLAN_CMD_TBTT_WAKEUP,
NULL);
if (pDevice->bChannelSwitch) {
pDevice->byChannelSwitchCount--;
if (pDevice->byChannelSwitchCount == 0)
- bScheduleCommand((void *) pDevice,
+ bScheduleCommand((void *)pDevice,
WLAN_CMD_11H_CHSW,
NULL);
}
}
LODWORD(pDevice->qwCurrTSF) = pINTData->dwLoTSF;
HIDWORD(pDevice->qwCurrTSF) = pINTData->dwHiTSF;
- /*DBG_PRN_GRP01(("ISR0 = %02x ,
+ /*DBG_PRN_GRP01(("ISR0 = %02x,
LoTsf = %08x,
HiTsf = %08x\n",
pINTData->byISR0,
@@ -205,7 +201,7 @@ void INTnsProcessData(PSDevice pDevice)
if (pINTData->byISR1 != 0)
if (pINTData->byISR1 & ISR_GPIO3)
- bScheduleCommand((void *) pDevice,
+ bScheduleCommand((void *)pDevice,
WLAN_CMD_RADIO,
NULL);
pDevice->intBuf.uDataLen = 0;
@@ -213,8 +209,8 @@ void INTnsProcessData(PSDevice pDevice)
pStats->tx_packets = pDevice->scStatistic.ullTsrOK;
pStats->tx_bytes = pDevice->scStatistic.ullTxDirectedBytes +
- pDevice->scStatistic.ullTxMulticastBytes +
- pDevice->scStatistic.ullTxBroadcastBytes;
+ pDevice->scStatistic.ullTxMulticastBytes +
+ pDevice->scStatistic.ullTxBroadcastBytes;
pStats->tx_errors = pDevice->scStatistic.dwTsrErr;
pStats->tx_dropped = pDevice->scStatistic.dwTsrErr;
}
diff --git a/drivers/staging/vt6656/int.h b/drivers/staging/vt6656/int.h
index a5d96b9..892c27e 100644
--- a/drivers/staging/vt6656/int.h
+++ b/drivers/staging/vt6656/int.h
@@ -36,31 +36,30 @@
/*--------------------- Export Definitions -------------------------*/
#pragma pack(1)
typedef struct tagSINTData {
- BYTE byTSR0;
- BYTE byPkt0;
- WORD wTime0;
- BYTE byTSR1;
- BYTE byPkt1;
- WORD wTime1;
- BYTE byTSR2;
- BYTE byPkt2;
- WORD wTime2;
- BYTE byTSR3;
- BYTE byPkt3;
- WORD wTime3;
- DWORD dwLoTSF;
- DWORD dwHiTSF;
- BYTE byISR0;
- BYTE byISR1;
- BYTE byRTSSuccess;
- BYTE byRTSFail;
- BYTE byACKFail;
- BYTE byFCSErr;
- BYTE abySW[2];
+ BYTE byTSR0;
+ BYTE byPkt0;
+ WORD wTime0;
+ BYTE byTSR1;
+ BYTE byPkt1;
+ WORD wTime1;
+ BYTE byTSR2;
+ BYTE byPkt2;
+ WORD wTime2;
+ BYTE byTSR3;
+ BYTE byPkt3;
+ WORD wTime3;
+ DWORD dwLoTSF;
+ DWORD dwHiTSF;
+ BYTE byISR0;
+ BYTE byISR1;
+ BYTE byRTSSuccess;
+ BYTE byRTSFail;
+ BYTE byACKFail;
+ BYTE byFCSErr;
+ BYTE abySW[2];
} __attribute__ ((__packed__))
SINTData, *PSINTData;
-
/*--------------------- Export Classes ----------------------------*/
/*--------------------- Export Variables --------------------------*/
--
1.7.11
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] Staging: vt6656: int.c: A few trivial style cleanups
2012-06-24 20:12 [PATCH] Staging: vt6656: int.c: A few trivial style cleanups Jesper Juhl
@ 2012-06-25 17:47 ` Greg Kroah-Hartman
2012-06-27 19:58 ` Jesper Juhl
0 siblings, 1 reply; 10+ messages in thread
From: Greg Kroah-Hartman @ 2012-06-25 17:47 UTC (permalink / raw)
To: Jesper Juhl
Cc: devel, Marcos Paulo de Souza, trivial, Forest Bond, linux-kernel
On Sun, Jun 24, 2012 at 10:12:12PM +0200, Jesper Juhl wrote:
> Removed a pointless cast + some whitespace cleanups.
Please break this up into different patches as you are doing multiple
things.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Staging: vt6656: int.c: A few trivial style cleanups
2012-06-25 17:47 ` Greg Kroah-Hartman
@ 2012-06-27 19:58 ` Jesper Juhl
2012-06-27 20:00 ` [PATCH 1/7] staging: vt6656: int: Redundant blank line removal Jesper Juhl
` (6 more replies)
0 siblings, 7 replies; 10+ messages in thread
From: Jesper Juhl @ 2012-06-27 19:58 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Marcos Paulo de Souza, trivial, Forest Bond, linux-kernel
On Mon, 25 Jun 2012, Greg Kroah-Hartman wrote:
> On Sun, Jun 24, 2012 at 10:12:12PM +0200, Jesper Juhl wrote:
> > Removed a pointless cast + some whitespace cleanups.
>
> Please break this up into different patches as you are doing multiple
> things.
>
Sure thing. A 7 patch series will follow this email.
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/7] staging: vt6656: int: Redundant blank line removal
2012-06-27 19:58 ` Jesper Juhl
@ 2012-06-27 20:00 ` Jesper Juhl
2012-06-27 20:00 ` [PATCH 2/7] staging: vt6656: int.h: Fix indentation and spacing Jesper Juhl
` (5 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Jesper Juhl @ 2012-06-27 20:00 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Marcos Paulo de Souza, trivial, Forest Bond, linux-kernel
This trivial cleanup patch removes some completely redundant blank
lines from drivers/staging/vt6656/int.[ch]
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
drivers/staging/vt6656/int.c | 4 ----
drivers/staging/vt6656/int.h | 1 -
2 files changed, 5 deletions(-)
diff --git a/drivers/staging/vt6656/int.c b/drivers/staging/vt6656/int.c
index 0a11423..36ed234 100644
--- a/drivers/staging/vt6656/int.c
+++ b/drivers/staging/vt6656/int.c
@@ -44,7 +44,6 @@
/* static int msglevel = MSG_LEVEL_DEBUG; */
static int msglevel = MSG_LEVEL_INFO;
-
/*--------------------- Static Classes ----------------------------*/
/*--------------------- Static Variables --------------------------*/
@@ -53,10 +52,8 @@ static int msglevel = MSG_LEVEL_INFO;
/*--------------------- Export Variables --------------------------*/
-
/*--------------------- Export Functions --------------------------*/
-
/*+
*
* Function: InterruptPollingThread
@@ -202,7 +199,6 @@ void INTnsProcessData(PSDevice pDevice)
pINTData->byISR0,
pINTData->byISR1);
}
-
if (pINTData->byISR1 != 0)
if (pINTData->byISR1 & ISR_GPIO3)
bScheduleCommand((void *) pDevice,
diff --git a/drivers/staging/vt6656/int.h b/drivers/staging/vt6656/int.h
index a5d96b9..3098630 100644
--- a/drivers/staging/vt6656/int.h
+++ b/drivers/staging/vt6656/int.h
@@ -60,7 +60,6 @@ typedef struct tagSINTData {
} __attribute__ ((__packed__))
SINTData, *PSINTData;
-
/*--------------------- Export Classes ----------------------------*/
/*--------------------- Export Variables --------------------------*/
--
1.7.11.1
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/7] staging: vt6656: int.h: Fix indentation and spacing
2012-06-27 19:58 ` Jesper Juhl
2012-06-27 20:00 ` [PATCH 1/7] staging: vt6656: int: Redundant blank line removal Jesper Juhl
@ 2012-06-27 20:00 ` Jesper Juhl
2012-06-27 20:01 ` [PATCH 3/7] staging: vt6656: int.c: Put comment about DEBUG print define on same line as code Jesper Juhl
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Jesper Juhl @ 2012-06-27 20:00 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Marcos Paulo de Souza, trivial, Forest Bond, linux-kernel
We use tabs for indentation and once space between variable types and
variable name.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
drivers/staging/vt6656/int.h | 42 +++++++++++++++++++++---------------------
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/vt6656/int.h b/drivers/staging/vt6656/int.h
index 3098630..3734e2c 100644
--- a/drivers/staging/vt6656/int.h
+++ b/drivers/staging/vt6656/int.h
@@ -36,27 +36,27 @@
/*--------------------- Export Definitions -------------------------*/
#pragma pack(1)
typedef struct tagSINTData {
- BYTE byTSR0;
- BYTE byPkt0;
- WORD wTime0;
- BYTE byTSR1;
- BYTE byPkt1;
- WORD wTime1;
- BYTE byTSR2;
- BYTE byPkt2;
- WORD wTime2;
- BYTE byTSR3;
- BYTE byPkt3;
- WORD wTime3;
- DWORD dwLoTSF;
- DWORD dwHiTSF;
- BYTE byISR0;
- BYTE byISR1;
- BYTE byRTSSuccess;
- BYTE byRTSFail;
- BYTE byACKFail;
- BYTE byFCSErr;
- BYTE abySW[2];
+ BYTE byTSR0;
+ BYTE byPkt0;
+ WORD wTime0;
+ BYTE byTSR1;
+ BYTE byPkt1;
+ WORD wTime1;
+ BYTE byTSR2;
+ BYTE byPkt2;
+ WORD wTime2;
+ BYTE byTSR3;
+ BYTE byPkt3;
+ WORD wTime3;
+ DWORD dwLoTSF;
+ DWORD dwHiTSF;
+ BYTE byISR0;
+ BYTE byISR1;
+ BYTE byRTSSuccess;
+ BYTE byRTSFail;
+ BYTE byACKFail;
+ BYTE byFCSErr;
+ BYTE abySW[2];
} __attribute__ ((__packed__))
SINTData, *PSINTData;
--
1.7.11.1
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/7] staging: vt6656: int.c: Put comment about DEBUG print define on same line as code
2012-06-27 19:58 ` Jesper Juhl
2012-06-27 20:00 ` [PATCH 1/7] staging: vt6656: int: Redundant blank line removal Jesper Juhl
2012-06-27 20:00 ` [PATCH 2/7] staging: vt6656: int.h: Fix indentation and spacing Jesper Juhl
@ 2012-06-27 20:01 ` Jesper Juhl
2012-06-27 20:01 ` [PATCH 4/7] staging: vt6656: int.c: Remove unneeded cast Jesper Juhl
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Jesper Juhl @ 2012-06-27 20:01 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Marcos Paulo de Souza, trivial, Forest Bond, linux-kernel
A small comment at the end of the line, mentioning the debug level, is
enough - no need to repeat the entire line of code just for that.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
drivers/staging/vt6656/int.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/vt6656/int.c b/drivers/staging/vt6656/int.c
index 36ed234..286ac3e 100644
--- a/drivers/staging/vt6656/int.c
+++ b/drivers/staging/vt6656/int.c
@@ -41,8 +41,7 @@
#include "usbpipe.h"
/*--------------------- Static Definitions -------------------------*/
-/* static int msglevel = MSG_LEVEL_DEBUG; */
-static int msglevel = MSG_LEVEL_INFO;
+static int msglevel = MSG_LEVEL_INFO; /* MSG_LEVEL_DEBUG */
/*--------------------- Static Classes ----------------------------*/
--
1.7.11.1
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/7] staging: vt6656: int.c: Remove unneeded cast
2012-06-27 19:58 ` Jesper Juhl
` (2 preceding siblings ...)
2012-06-27 20:01 ` [PATCH 3/7] staging: vt6656: int.c: Put comment about DEBUG print define on same line as code Jesper Juhl
@ 2012-06-27 20:01 ` Jesper Juhl
2012-06-27 20:02 ` [PATCH 5/7] staging: vt6656: int.c: Use one space between variable type and name Jesper Juhl
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Jesper Juhl @ 2012-06-27 20:01 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Marcos Paulo de Souza, trivial, Forest Bond, linux-kernel
When assigning a void* to a variable <of some other type>, the value
is cast implicitly - there's no need for explicit cast.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
drivers/staging/vt6656/int.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/int.c b/drivers/staging/vt6656/int.c
index 286ac3e..e7f6624 100644
--- a/drivers/staging/vt6656/int.c
+++ b/drivers/staging/vt6656/int.c
@@ -77,7 +77,7 @@ static int msglevel = MSG_LEVEL_INFO; /* MSG_LEVEL_DEBUG */
-*/
void INTvWorkItem(void *Context)
{
- PSDevice pDevice = (PSDevice) Context;
+ PSDevice pDevice = Context;
int ntStatus;
DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"---->Interrupt Polling Thread\n");
--
1.7.11.1
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 5/7] staging: vt6656: int.c: Use one space between variable type and name
2012-06-27 19:58 ` Jesper Juhl
` (3 preceding siblings ...)
2012-06-27 20:01 ` [PATCH 4/7] staging: vt6656: int.c: Remove unneeded cast Jesper Juhl
@ 2012-06-27 20:02 ` Jesper Juhl
2012-06-27 20:02 ` [PATCH 6/7] staging: vt6656: int.c: We don't use spaces between a cast and the variable being converted Jesper Juhl
2012-06-27 20:03 ` [PATCH 7/7] staging: vt6656: int.c: correct indentation to use tabs rather than spaces Jesper Juhl
6 siblings, 0 replies; 10+ messages in thread
From: Jesper Juhl @ 2012-06-27 20:02 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Marcos Paulo de Souza, trivial, Forest Bond, linux-kernel
The style of most kernel code is that there is 1 *space* between the
type of a variable and its name. This patch enforces that in
drivers/staging/vt6656/int.c .
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
drivers/staging/vt6656/int.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vt6656/int.c b/drivers/staging/vt6656/int.c
index e7f6624..40605c8 100644
--- a/drivers/staging/vt6656/int.c
+++ b/drivers/staging/vt6656/int.c
@@ -90,8 +90,8 @@ void INTvWorkItem(void *Context)
void INTnsProcessData(PSDevice pDevice)
{
- PSINTData pINTData;
- PSMgmtObject pMgmt = &(pDevice->sMgmtObj);
+ PSINTData pINTData;
+ PSMgmtObject pMgmt = &(pDevice->sMgmtObj);
struct net_device_stats *pStats = &pDevice->stats;
DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"---->s_nsInterruptProcessData\n");
--
1.7.11.1
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 6/7] staging: vt6656: int.c: We don't use spaces between a cast and the variable being converted
2012-06-27 19:58 ` Jesper Juhl
` (4 preceding siblings ...)
2012-06-27 20:02 ` [PATCH 5/7] staging: vt6656: int.c: Use one space between variable type and name Jesper Juhl
@ 2012-06-27 20:02 ` Jesper Juhl
2012-06-27 20:03 ` [PATCH 7/7] staging: vt6656: int.c: correct indentation to use tabs rather than spaces Jesper Juhl
6 siblings, 0 replies; 10+ messages in thread
From: Jesper Juhl @ 2012-06-27 20:02 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Marcos Paulo de Souza, trivial, Forest Bond, linux-kernel
Remove spaces between casts and variables from
drivers/staging/vt6656/int.c .
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
drivers/staging/vt6656/int.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vt6656/int.c b/drivers/staging/vt6656/int.c
index 40605c8..e9fab45 100644
--- a/drivers/staging/vt6656/int.c
+++ b/drivers/staging/vt6656/int.c
@@ -99,8 +99,8 @@ void INTnsProcessData(PSDevice pDevice)
pINTData = (PSINTData) pDevice->intBuf.pDataBuf;
if (pINTData->byTSR0 & TSR_VALID) {
STAvUpdateTDStatCounter(&(pDevice->scStatistic),
- (BYTE) (pINTData->byPkt0 & 0x0F),
- (BYTE) (pINTData->byPkt0>>4),
+ (BYTE)(pINTData->byPkt0 & 0x0F),
+ (BYTE)(pINTData->byPkt0>>4),
pINTData->byTSR0);
BSSvUpdateNodeTxCounter(pDevice,
&(pDevice->scStatistic),
@@ -110,8 +110,8 @@ void INTnsProcessData(PSDevice pDevice)
}
if (pINTData->byTSR1 & TSR_VALID) {
STAvUpdateTDStatCounter(&(pDevice->scStatistic),
- (BYTE) (pINTData->byPkt1 & 0x0F),
- (BYTE) (pINTData->byPkt1>>4),
+ (BYTE)(pINTData->byPkt1 & 0x0F),
+ (BYTE)(pINTData->byPkt1>>4),
pINTData->byTSR1);
BSSvUpdateNodeTxCounter(pDevice,
&(pDevice->scStatistic),
@@ -121,8 +121,8 @@ void INTnsProcessData(PSDevice pDevice)
}
if (pINTData->byTSR2 & TSR_VALID) {
STAvUpdateTDStatCounter(&(pDevice->scStatistic),
- (BYTE) (pINTData->byPkt2 & 0x0F),
- (BYTE) (pINTData->byPkt2>>4),
+ (BYTE)(pINTData->byPkt2 & 0x0F),
+ (BYTE)(pINTData->byPkt2>>4),
pINTData->byTSR2);
BSSvUpdateNodeTxCounter(pDevice,
&(pDevice->scStatistic),
@@ -132,8 +132,8 @@ void INTnsProcessData(PSDevice pDevice)
}
if (pINTData->byTSR3 & TSR_VALID) {
STAvUpdateTDStatCounter(&(pDevice->scStatistic),
- (BYTE) (pINTData->byPkt3 & 0x0F),
- (BYTE) (pINTData->byPkt3>>4),
+ (BYTE)(pINTData->byPkt3 & 0x0F),
+ (BYTE)(pINTData->byPkt3>>4),
pINTData->byTSR3);
BSSvUpdateNodeTxCounter(pDevice,
&(pDevice->scStatistic),
--
1.7.11.1
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 7/7] staging: vt6656: int.c: correct indentation to use tabs rather than spaces
2012-06-27 19:58 ` Jesper Juhl
` (5 preceding siblings ...)
2012-06-27 20:02 ` [PATCH 6/7] staging: vt6656: int.c: We don't use spaces between a cast and the variable being converted Jesper Juhl
@ 2012-06-27 20:03 ` Jesper Juhl
6 siblings, 0 replies; 10+ messages in thread
From: Jesper Juhl @ 2012-06-27 20:03 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Marcos Paulo de Souza, trivial, Forest Bond, linux-kernel
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
drivers/staging/vt6656/int.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vt6656/int.c b/drivers/staging/vt6656/int.c
index e9fab45..eba4b50 100644
--- a/drivers/staging/vt6656/int.c
+++ b/drivers/staging/vt6656/int.c
@@ -182,11 +182,11 @@ void INTnsProcessData(PSDevice pDevice)
LODWORD(pDevice->qwCurrTSF) = pINTData->dwLoTSF;
HIDWORD(pDevice->qwCurrTSF) = pINTData->dwHiTSF;
/*DBG_PRN_GRP01(("ISR0 = %02x ,
- LoTsf = %08x,
- HiTsf = %08x\n",
- pINTData->byISR0,
- pINTData->dwLoTSF,
- pINTData->dwHiTSF)); */
+ LoTsf = %08x,
+ HiTsf = %08x\n",
+ pINTData->byISR0,
+ pINTData->dwLoTSF,
+ pINTData->dwHiTSF)); */
STAvUpdate802_11Counter(&pDevice->s802_11Counter,
&pDevice->scStatistic,
@@ -208,8 +208,8 @@ void INTnsProcessData(PSDevice pDevice)
pStats->tx_packets = pDevice->scStatistic.ullTsrOK;
pStats->tx_bytes = pDevice->scStatistic.ullTxDirectedBytes +
- pDevice->scStatistic.ullTxMulticastBytes +
- pDevice->scStatistic.ullTxBroadcastBytes;
+ pDevice->scStatistic.ullTxMulticastBytes +
+ pDevice->scStatistic.ullTxBroadcastBytes;
pStats->tx_errors = pDevice->scStatistic.dwTsrErr;
pStats->tx_dropped = pDevice->scStatistic.dwTsrErr;
}
--
1.7.11.1
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-06-27 20:03 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-24 20:12 [PATCH] Staging: vt6656: int.c: A few trivial style cleanups Jesper Juhl
2012-06-25 17:47 ` Greg Kroah-Hartman
2012-06-27 19:58 ` Jesper Juhl
2012-06-27 20:00 ` [PATCH 1/7] staging: vt6656: int: Redundant blank line removal Jesper Juhl
2012-06-27 20:00 ` [PATCH 2/7] staging: vt6656: int.h: Fix indentation and spacing Jesper Juhl
2012-06-27 20:01 ` [PATCH 3/7] staging: vt6656: int.c: Put comment about DEBUG print define on same line as code Jesper Juhl
2012-06-27 20:01 ` [PATCH 4/7] staging: vt6656: int.c: Remove unneeded cast Jesper Juhl
2012-06-27 20:02 ` [PATCH 5/7] staging: vt6656: int.c: Use one space between variable type and name Jesper Juhl
2012-06-27 20:02 ` [PATCH 6/7] staging: vt6656: int.c: We don't use spaces between a cast and the variable being converted Jesper Juhl
2012-06-27 20:03 ` [PATCH 7/7] staging: vt6656: int.c: correct indentation to use tabs rather than spaces Jesper Juhl
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.