From: Tejun Heo <tj@kernel.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Mike Christie <michaelc@cs.wisc.edu>,
Jens Axboe <axboe@kernel.dk>,
Jun'ichi Nomura <j-nomura@ce.jp.nec.com>,
Stefan Richter <stefanr@s5r6.in-berlin.de>
Subject: Re: [PATCH 2/4] scsi: Fix device removal NULL pointer dereference
Date: Mon, 25 Jun 2012 14:21:07 -0700 [thread overview]
Message-ID: <20120625212107.GM3869@google.com> (raw)
In-Reply-To: <1340658889.2980.51.camel@dabdike.int.hansenpartnership.com>
Hey, James.
On Mon, Jun 25, 2012 at 10:14:49PM +0100, James Bottomley wrote:
> > @@ -1490,11 +1489,7 @@ static void scsi_request_fn(struct request_queue *q)
> > struct scsi_cmnd *cmd;
> > struct request *req;
> >
> > - if (!sdev) {
> > - while ((req = blk_peek_request(q)) != NULL)
> > - scsi_kill_request(req, q);
> > - return;
> > - }
>
> That means that this hunk of code has to stay, but needs to be gated on
> blk_queue_dead(q); there's still a race where this can occur.
Wouldn't the scsi_device_online() check down below be enough? Block
layer drain is gonna loop until all requests are done, so the looping
is handled from block layer.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-06-25 21:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 18:12 [PATCH 0/4 v9] SCSI device removal fixes Bart Van Assche
2012-06-25 18:14 ` [PATCH 1/4] block: Fix blk_execute_rq_nowait() dead queue handling Bart Van Assche
2012-06-25 18:41 ` Tejun Heo
2012-06-25 19:18 ` Muthu Kumar
2012-06-25 18:15 ` [PATCH 2/4] scsi: Fix device removal NULL pointer dereference Bart Van Assche
2012-06-25 20:36 ` Tejun Heo
2012-06-25 21:14 ` James Bottomley
2012-06-25 21:21 ` Tejun Heo [this message]
2012-06-25 21:35 ` James Bottomley
2012-06-26 7:02 ` Bart Van Assche
2012-06-25 22:05 ` Mike Christie
2012-06-26 7:19 ` James Bottomley
2012-06-26 7:26 ` Bart Van Assche
2012-06-26 6:46 ` Bart Van Assche
2012-06-26 7:25 ` James Bottomley
2012-06-26 10:00 ` Bart Van Assche
2012-06-26 9:13 ` Mike Christie
2012-06-26 10:03 ` Bart Van Assche
2012-06-26 15:03 ` Hannes Reinecke
2012-06-25 18:16 ` [PATCH 3/4] scsi: Change return type of scsi_queue_insert() into void Bart Van Assche
2012-06-25 18:17 ` [PATCH 4/4] scsi: Stop accepting SCSI requests before removing a device Bart Van Assche
2012-06-25 20:42 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2012-06-07 18:39 [PATCH 0/4 v8] Fixes for SCSI device removal Bart Van Assche
2012-06-07 18:43 ` [PATCH 2/4] scsi: Fix device removal NULL pointer dereference Bart Van Assche
2012-06-05 17:08 [PATCH 0/4 v7] Fixes for SCSI device removal Bart Van Assche
2012-06-05 17:11 ` [PATCH 2/4] scsi: Fix device removal NULL pointer dereference Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120625212107.GM3869@google.com \
--to=tj@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.