From: David McCullough <david_mccullough@mcafee.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH] net/ipv6/route.c: packets originating on device match lo
Date: Tue, 26 Jun 2012 11:38:31 +1000 [thread overview]
Message-ID: <20120626013831.GA3455@mcafee.com> (raw)
In-Reply-To: <20120625.162832.804773711822642700.davem@davemloft.net>
Jivin David Miller lays it down ...
> From: David McCullough <david_mccullough@mcafee.com>
> Date: Mon, 25 Jun 2012 16:50:30 +1000
>
> > @@ -931,6 +931,9 @@ struct dst_entry * ip6_route_output(stru
> > {
> > int flags = 0;
> >
> > + if (fl6->flowi6_iif == 0)
> > + fl6->flowi6_iif = net->loopback_dev->ifindex;
> > +
>
> Like ipv4, you should make this assignment unconditionally.
No problems, will resend, I wasn't so sure that I could do that safely
with the flowi getting passed into IPv6 rather than created as it is in
IPv4. Did some extra testing, looks good so patch to follow,
Thanks,
Davidm
--
David McCullough, david_mccullough@mcafee.com, Ph:+61 734352815
McAfee - SnapGear http://www.mcafee.com http://www.uCdot.org
prev parent reply other threads:[~2012-06-26 1:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 6:50 [PATCH] net/ipv6/route.c: packets originating on device match lo David McCullough
2012-06-25 23:28 ` David Miller
2012-06-26 1:38 ` David McCullough [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626013831.GA3455@mcafee.com \
--to=david_mccullough@mcafee.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.