From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: Liam Girdwood <lrg@ti.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: core: Only delay if we successfully set the voltage
Date: Tue, 26 Jun 2012 11:40:29 +0100 [thread overview]
Message-ID: <20120626104028.GO30406@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAF+7xWkj+aFc_Kq7PzAoYrUa0tCs1sq7K2=bc-tVXJH4x+7DRw@mail.gmail.com>
On Tue, Jun 26, 2012 at 06:30:16PM +0800, Axel Lin wrote:
> > /* Call set_voltage_time_sel if successfully obtained old_selector */
> > - if (_regulator_is_enabled(rdev) && ret == 0 && old_selector >= 0 &&
> ^^^^^^^^
> We
> already check ret ==0 here.
Your mailer is seriously messing up your formatting - the indentation is
nothing to do with what you're trying to point at...
The checks do need to be reordered here, though - we should check the
return value first.
prev parent reply other threads:[~2012-06-26 10:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 10:26 [PATCH 1/2] regulator: core: Only delay if we successfully set the voltage Mark Brown
2012-06-26 10:26 ` [PATCH 2/2] regulator: core: Check that the selector from map_voltage() is valid Mark Brown
2012-06-26 12:40 ` Axel Lin
2012-06-26 13:13 ` Mark Brown
2012-06-26 10:30 ` [PATCH 1/2] regulator: core: Only delay if we successfully set the voltage Axel Lin
2012-06-26 10:40 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626104028.GO30406@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.